Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110138
Content-Type: text/plain;
	charset=us-ascii
In-Reply-To: <CAESVnVq7ZeJvb5M9TNFpa6_=YmuFMxmReW5BGa_cNMTbziV1sg@mail.gmail.com>
Date: Tue, 12 May 2020 15:08:43 +0200
Cc: Nikita Popov <nikita.ppv@gmail.com>,
 PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID:
 <VI1PR02MB470324A472337D9120F6C1AEE2BE0@VI1PR02MB4703.eurprd02.prod.outlook.com>
References: <CAF+90c8BeG9GwQOVypcNe3p5Yp9LefsWHfH5Wrjq1o6HZvrZVQ@mail.gmail.com>
 <CAF+90c_mfx3fbwWGusKH+LdXcMV7g-EiX5H15-AAWmhPSxnLAA@mail.gmail.com>
 <CAESVnVq7ZeJvb5M9TNFpa6_=YmuFMxmReW5BGa_cNMTbziV1sg@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2001:7e8:cb47:6400:b8a8:c0af:c0:e8b7] (2001:7e8:cb47:6400:b8a8:c0af:c0:e8b7) by PR0P264CA0176.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28 via Frontend Transport; Tue, 12 May 2020 13:08:44 +0000
X-Mailer: Apple Mail (2.3445.104.11)
X-Microsoft-Original-Message-ID:
 <B22E3384-9941-42FB-B5CF-D945B0612009@hotmail.com>
X-TMN: [2D56e1Wjp7n9cAaBnkZegqALCdjMM4iF+6se9Wc3dKQDuXCMRaTxcV2TNp4aPrCb]
X-MS-PublicTrafficType: Email
X-IncomingHeaderCount: 50
X-EOPAttributedMessage: 0
X-MS-Office365-Filtering-Correlation-Id: 1ad7e178-bd12-4cde-6454-08d7f67599f9
X-MS-TrafficTypeDiagnostic: DB3EUR04HT129:
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	SRCLESSEdOKhHg9VRr3aDdd/Ongg0U4NBoLp7saIibd3GR06b6PE2r94S7/IRmcREIgJUXBllzw00SKOLdQlpEt4yOKRY1g9F07ZbJTM8wFkxnkQdA3TpnFEFTJawdb00PaoBKVaqrxJWdeZpSCCY9jYAZXrG+tR2QlKre/HQXRcqnO3eXpbw959EoyvdrRsTNZ3mlKkoYRjbywkol+2eA==
X-Forefront-Antispam-Report:
	CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR02MB4703.eurprd02.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901;
X-MS-Exchange-AntiSpam-MessageData:
	Fjp14gYH0nleQeKZvmXLC/D1LWHXGYujQ9Bjlp1N4FseeVvTx3QElpUkwejcVBtOY1eFV4ppfrn75OlQIDqHKWc6dEZk+1zSmhbHPP/oH8c1WHWbKPbAurDe9RrN4uDc1uoNZozBJEkG63pV+Rgby7L82GIdvDecP1q0ygMIxX1293bhrlymfe2vUl27WffuzMs6i3ygTaclZlYdHjgfSg==
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ad7e178-bd12-4cde-6454-08d7f67599f9
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2020 13:08:45.7385
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-FromEntityHeader: Internet
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3EUR04HT129
Subject: Re: [PHP-DEV] Re: Making all Traversables an Iterator or
 IteratorAggregate
From: bobwei9@hotmail.com (Bob Weinand)

Hey Sara,

> Am 12.05.2020 um 14:49 schrieb Sara Golemon <pollita@php.net>:
>=20
> On Tue, May 12, 2020 at 3:26 AM Nikita Popov <nikita.ppv@gmail.com> wrote=
:
>> // WeakMap::getIterator(): Iterator
>> ZEND_METHOD(WeakMap, getIterator)
>> {
>>    if (zend_parse_parameters_none() =3D=3D FAILURE) {
>>        return;
>>    }
>>    zend_create_internal_iterator_zval(return_value, ZEND_THIS);
>> }
>>=20
> Given that the body of this method seems to usually (always?) be the same=
,
> why not define it in InternalIterator and allow it to be inherited?

Good idea.

>> There's some bikeshed potential here regarding the class name.
>>=20
> Not personally over-picky, but I do agree that "Internal*" is a bit
> awkward.  Unfortunately there's not much that's better and appropriate fo=
r
> exposing to scripts.  This might be one of those rare occasions where
> exposing "Zend" into userspace makes sense.  "PHP" is overloaded into
> several meanings that are significant for userspace developers, but
> something like "ZendIterator" might convey the right level of "This has t=
o
> do with the engine, please move along".  Or maybe go verbose:
> 'IteratorForExtensionClassImplementations'. :p

We call the engine Zend, but eih, that's a rather internal detail we mostly=
 don't leak into userland, and I wouldn't do it here either.
InternalIterator is the better choice I think.

>> ZEND_ASSERT(scope->get_iterator !=3D zend_user_it_get_new_iterator); >
> Does this mean that if I do `class Foo implements InternalIterator {}` in=
 a
> script, I can assert (crash) PHP? I don't see anything obvious (at a
> glance) preventing me from inheriting from InternalIterator.

The class is marked final, so userland won't be able to directly extend it.=
 (zend_ce_internal_iterator->ce_flags |=3D ZEND_ACC_FINAL;)

Bob=