Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110130
To: Eliot Lear <lear@lear.ch>, internals@lists.php.net
References: <fcccdf25-b1f1-a2c7-ffc9-2a19f04ecf38@lear.ch>
Message-ID: <8c7f1f4d-e12f-7bd6-73e8-a491937e46b2@gmx.de>
Date: Mon, 11 May 2020 12:45:14 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <fcccdf25-b1f1-a2c7-ffc9-2a19f04ecf38@lear.ch>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: PR #5251 adds support for CMS (RFC5662)
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 11.05.2020 at 11:59, Eliot Lear wrote:

> Hi everyone,
>
> I am new to the PHP development process, so please forgive me if I have
> this wrong.
>
> In PR #5251[1] I=E2=80=99ve created OpenSSL CMS functions that are nearl=
y direct
> analogues to the openssl PKCS#7 functions.=C2=A0 Cryptographic Message S=
yntax
> is defined in RFC 5652[2], and is a follow-on to PKCS#7.=C2=A0 These
> functions are useful to developers who are creating or verifying
> PKI-based signatures (this is the case for me or anyone else who is
> implementing or deploying RFC 8520[3]), and there are other IoT services
> that are using CMS as well (not to mention certain modern mailing system=
s).
>
> There are one or two changes- one can specify the encoding format as an
> argument, for instance, and error out out the use of DETACHED with
> S/MIME encoding, as nobody seems to know what that would mean.
>
> I=E2=80=99ve been working with Jakub and others who have been very gener=
ous with
> their time on code reviews.=C2=A0 I would be grateful for any additional
> feedback you would have, with an eye toward merging this PR.=C2=A0 The P=
R is
> already marked as RFC I have not yet formalized that.(*)
>
> Best regards,
>
> Eliot
>
> (*) I tried adding an RFC page on the wiki, but sensibly, as I just
> created the account, the system did not permit me to do so.
>
> [1] https://github.com/php/php-src/pull/5251
> [2] https://www.rfc-editor.org/rfc/rfc5652.html
> [3] https://www.rfc-editor.org/rfc/rfc8520.html

Thanks for working on CMS support!

I have granted you RFC karma.  Best of luck with the RFC. :)

=2D-
Christoph M. Becker