Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110108
To: Benjamin Eberlei <kontakt@beberlei.de>,
 PHP Internals <internals@lists.php.net>
References: <CAEPJdunD-71fm43zjvvs7myqhNFr58+p8sSv9Pgi3GwSQFKoDg@mail.gmail.com>
Message-ID: <fb6e03c1-6a7c-ba45-ca0d-a0cf56478725@gmx.de>
Date: Sun, 10 May 2020 17:58:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <CAEPJdunD-71fm43zjvvs7myqhNFr58+p8sSv9Pgi3GwSQFKoDg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: xmlrpc_errors INI setting
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 28.04.2020 at 21:03, Benjamin Eberlei wrote:

> Hey,
>
> while working on cleanups for the internal error handling code,
> specifically extracting different rendering logic into pluggable hooks (
> https://github.com/php/php-src/pull/5484) I came across the ini settings
> "xmlrpc_errors" and "xmlrpc_error_number", prominently integrated and us=
ed
> in main/main.c
>
> Both are used to allow users to change the display rendering of errors
> while display_errors=3D1 and these settings were added in 2001 and nothi=
ng
> changed much about this since then.
>
> I am wondering if this code is not better moved to ext/xmlrpc extension
> instead of being in main/main.c - this would be similar to how ext/soap
> handles errors in the extension already.
>
> Downsides:
>
> - People can currently use this setting when doing their own xmlrpc,
> however that anyone uses this setting looks so unlikely, because its glo=
bal
> - With the potential unbundling of ext/xmlrpc this could also mean the i=
ni
> settings get moved out of core entirely.
>
> Do you think this small BC break moving the settings to ext/xmlrpc is
> acceptable as part of decoupling error displaying from php_error_cb and
> main.c?
>
> Has anyone seen this been used in a project?

Since display_errors=3DOn is a development feature, we would not even
break production code if we *removed* it.  Moving it to the xmlrpc
extension looks fine to me.  If anybody will complain that they need the
setting for XMLRPC functionality which is not implemented on top of the
xmlrpc extension, we could still consider to offer a minimal extension
which just supports these INI settings.  However, I do not expect
anybody complaining about that.

Thanks for working on disentangling the error handling!

=2D-
Christoph M. Becker