Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110085
MIME-Version: 1.0
References: <171dee3baf3.bef5753260554.3262181919550021853@manuelcanga.dev>
 <CAKuGYLQ7s7Xbf1bHw83aDW0=2mNT9mkZ0XTHMz9t69EUGxvUyA@mail.gmail.com>
 <171e05b4ced.1041f31b5124598.4028595156690203917@manuelcanga.dev>
 <10faa29f-f08f-a73e-b76d-683f5abbee86@gmail.com> <171f30b0df0.102b810be444185.2462173785894899100@manuelcanga.dev>
In-Reply-To: <171f30b0df0.102b810be444185.2462173785894899100@manuelcanga.dev>
Date: Fri, 8 May 2020 14:07:13 +0100
Message-ID: <CA+kxMuQEz+S4P95b4BP7bB90Vj81h2ZngVw_xqu9gnTBB97pWw@mail.gmail.com>
To: Manuel Canga <php@manuelcanga.dev>
Cc: Rowan Tommins <rowan.collins@gmail.com>, internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] Keep type of reference params
From: Danack@basereality.com (Dan Ackroyd)

On Fri, 8 May 2020 at 07:49, Manuel Canga <php@manuelcanga.dev> wrote:
>
> What is your opinion ? Do you see it useful ?

I can see the need; I strongly dislike the idea of using references for this.

What you're describing is a form of 'out parameters' which have been
mentioned a few times before on this list.

I've made a note of the general idea here:
https://github.com/Danack/RfcCodex/blob/master/out_parameters.md

Though the wikipedia article is also good:
https://en.wikipedia.org/wiki/Parameter_(computer_programming)#Output_parameters

Using references for things like this is a bad idea as references make
it hard to reason about code. In this specific case, having the
function mutate the existing variable is horrible.

> If nobody objects to this RFC

While you categorically must do what you must, I don't think you will
get much benefit  from raising this as an RFC until you find someone
who can and is willing to implement it.

Actually, just finding any core contributor who is willing to say that
they would back this idea might be a good idea.

And yes, phpinternals could still really do with an 'informal but only
to open to voters' feedback mechanism. Someone should do something
about that....wait I'm _someone_. And I have wiki permissions.

So here's a page for a non-binding 'indication of interest' poll:
https://wiki.php.net/indication_of_interest/keep_type_of_reference_params

If anyone disagrees with the text, either please suggest a change or
edit it if you have karma.

cheers
Dan
Ack