Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110039
To: "G. P. B." <george.banyard@gmail.com>, Xinchen Hui <laruence@php.net>
Cc: PHP internals <internals@lists.php.net>
References: <a8c47226-c544-b0b0-e16a-14a8e88cd7bb@gmx.de>
 <CABBJUpft6gqGOZxx3weR+BY1W9dceuVZvSU_-FfvTVBo5St4vA@mail.gmail.com>
 <CAFPFaMKx13NDKJPysiJfYaePxB3vhDgVbmTtw+ohmb06e1V0QA@mail.gmail.com>
Message-ID: <d03647a7-5c8b-1856-b870-2418cd8a7b9a@gmx.de>
Date: Wed, 6 May 2020 13:06:27 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <CAFPFaMKx13NDKJPysiJfYaePxB3vhDgVbmTtw+ohmb06e1V0QA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Update coding standards wrt. C99?
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 06.05.2020 at 12:52, G. P. B. wrote:

> On Wed, 6 May 2020 at 12:20, Xinchen Hui <laruence@php.net> wrote:
>
>> mixing declarations and codes sometimes brings unexpected
>> varaibles overriden and hard to debugging.
>
> In a perfect world we would be able to enable the -Wshadow GCC
> compiler warning which would shout when such bugs could pop out,
> however variable shadowing is pretty common in the engine, and
> unless someone knows a way to "baseline" the current warnings such
> that only new/refactored code warns it seems like a long shot to get
> to a state where we can do that.

Isn't variable shadowing only an issue with nested blocks?

=2D-
Christoph M. Becker