Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110037
MIME-Version: 1.0
References: <a8c47226-c544-b0b0-e16a-14a8e88cd7bb@gmx.de> <CABBJUpft6gqGOZxx3weR+BY1W9dceuVZvSU_-FfvTVBo5St4vA@mail.gmail.com>
In-Reply-To: <CABBJUpft6gqGOZxx3weR+BY1W9dceuVZvSU_-FfvTVBo5St4vA@mail.gmail.com>
Date: Wed, 6 May 2020 12:52:26 +0200
Message-ID: <CAFPFaMKx13NDKJPysiJfYaePxB3vhDgVbmTtw+ohmb06e1V0QA@mail.gmail.com>
To: Xinchen Hui <laruence@php.net>
Cc: "Christoph M. Becker" <cmbecker69@gmx.de>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000000c02de05a4f89057"
Subject: Re: [PHP-DEV] Update coding standards wrt. C99?
From: george.banyard@gmail.com ("G. P. B.")

--0000000000000c02de05a4f89057
Content-Type: text/plain; charset="UTF-8"

On Wed, 6 May 2020 at 12:20, Xinchen Hui <laruence@php.net> wrote:

> mixing declarations and codes sometimes brings unexpected
> varaibles overriden and hard to debugging.
>
> thanks
>
> --
> Xinchen Hui
> @Laruence
> http://www.laruence.com/


In a perfect world we would be able to enable the -Wshadow GCC
compiler warning which would shout when such bugs could pop out,
however variable shadowing is pretty common in the engine, and
unless someone knows a way to "baseline" the current warnings such
that only new/refactored code warns it seems like a long shot to get
to a state where we can do that.

Another related concern may be that a variable is not yet initialized,
which can be flagged using -W-jump-misses-init, however due to a
couple of limitations enabling it is not feasible without some small
compromises, see https://github.com/php/php-src/pull/5389

Best regards

George P. Banyard

--0000000000000c02de05a4f89057--