Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110035
MIME-Version: 1.0
References: <a8c47226-c544-b0b0-e16a-14a8e88cd7bb@gmx.de>
In-Reply-To: <a8c47226-c544-b0b0-e16a-14a8e88cd7bb@gmx.de>
Date: Wed, 6 May 2020 18:20:18 +0800
Message-ID: <CABBJUpft6gqGOZxx3weR+BY1W9dceuVZvSU_-FfvTVBo5St4vA@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000000d9dc305a4f81d3a"
Subject: Re: [PHP-DEV] Update coding standards wrt. C99?
From: laruence@php.net (Xinchen Hui)

--0000000000000d9dc305a4f81d3a
Content-Type: text/plain; charset="UTF-8"

Hey:

On Wed, May 6, 2020 at 3:32 PM Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> Hi all,
>
> since master requires (mostly) C99 compliant compilers anyway, I wonder
> if we like to update our coding standards[1], to reflect:
>
>  * that we require (mostly) C99 compliant compilers (instead of ANSI-C
> compliant compilers)
>
>  * that mixing of declarations and statements is fine
>
 IMO, mixing variables and codes are always not a good practice, strict is
always means tidy..

 mixing declarations and codes sometimes brings unexpected
varaibles overriden and hard to debugging.

 and, I don't think make variables declaration at top of a block is a hard
thing to do.

thanks

>  * that C++ style comments are now allowed, or maybe that they are still
> forbidden (in the latter case the stated reasons should be updated)
>
> We may also consider to drop the "Documentation and folding hooks"[2]
> section; besides that it is already partially outdated (AIUI,
> doc/genfuncsummary is superseeded by doc/docgen for a long time), I
> don't think these folding markers encapsulating each individual function
> are useful nowadays.
>
> Thoughts?
>
> [1] <https://github.com/php/php-src/blob/master/CODING_STANDARDS.md>
> [2]
> <
> https://github.com/php/php-src/blob/master/CODING_STANDARDS.md#documentation-and-folding-hooks
> >
>
> --
> Christoph M. Becker
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>


-- 
Xinchen Hui
@Laruence
http://www.laruence.com/

--0000000000000d9dc305a4f81d3a--