Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:110033
MIME-Version: 1.0
References: <a8c47226-c544-b0b0-e16a-14a8e88cd7bb@gmx.de>
In-Reply-To: <a8c47226-c544-b0b0-e16a-14a8e88cd7bb@gmx.de>
Date: Wed, 6 May 2020 09:53:20 +0200
Message-ID: <CAF+90c_LHF4F2CQGR8GKqRtYysFj0dE-Dpkd8=Ztw-QPg-zvpQ@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000bb556d05a4f60f24"
Subject: Re: [PHP-DEV] Update coding standards wrt. C99?
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000bb556d05a4f60f24
Content-Type: text/plain; charset="UTF-8"

On Wed, May 6, 2020 at 9:32 AM Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> Hi all,
>
> since master requires (mostly) C99 compliant compilers anyway, I wonder
> if we like to update our coding standards[1], to reflect:
>
>  * that we require (mostly) C99 compliant compilers (instead of ANSI-C
> compliant compilers)
>
>  * that mixing of declarations and statements is fine
>

Sounds good. This restriction going away has been a great quality of life
improvement when working on master.


>  * that C++ style comments are now allowed, or maybe that they are still
> forbidden (in the latter case the stated reasons should be updated)
>

It seems like in practice the style is basically /* */ for most comments
and // for TODO comments. Not sure how that came about :) No strong opinion
on whether to keep it that way or not.

We may also consider to drop the "Documentation and folding hooks"[2]
> section; besides that it is already partially outdated (AIUI,
> doc/genfuncsummary is superseeded by doc/docgen for a long time), I
> don't think these folding markers encapsulating each individual function
> are useful nowadays.
>

Yes, this section should be dropped. We should also drop all existing
folding marks when someone has time to come up with the right regular
expressions for that. They're a lot of noise, regularly broken and not
actually needed by any decent tooling (including vim, no idea about emacs,
but I would be very surprised if it did not support code structure based
folding).

Regards,
Nikita

--000000000000bb556d05a4f60f24--