Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109968
Message-ID: <8072D361-DAA2-44D3-B0E4-F656169F2BBB@benramsey.com>
Content-Type: multipart/signed;
	boundary="Apple-Mail=_1030FD48-7F7B-480F-884C-39CEAC46E4AA";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
Date: Sat, 2 May 2020 12:14:14 -0500
In-Reply-To: <CANaX5nfM8AZmCsvFB7C_Bbx_jQdtgTLaKYi+_JrdFv7ki=_53Q@mail.gmail.com>
Cc: Benas IML <benas.molis.iml@gmail.com>,
 Chase Peeler <chasepeeler@gmail.com>,
 =?utf-8?Q?C=C3=B4me_Chilliet?= <come.chilliet@fusiondirectory.org>,
 PHP Internals List <internals@lists.php.net>
To: Davey Shafik <davey@php.net>
References: <CANeKSiRbPFbP9GjWdwbQ3J4oLP2wjKGoxnz1EbVb9K0aejg4EQ@mail.gmail.com>
 <CADyq6sLw8tKcqV0ukjbkey5tXEraTk6zzbbTXB8_0_wO0xO6jQ@mail.gmail.com>
 <CANeKSiQJuMkF0Hyc+8GDoUVc_MNs_xtt+y97qv+LMuOCAtotEQ@mail.gmail.com>
 <4063585.LhOdPkFbeG@mcmic-probook>
 <CANeKSiRq4GDwHEk8Jyxf8LmC2V0Aqdeouki+BytxwShzJ1KaFQ@mail.gmail.com>
 <CAPKYkKzkUt=TerFmn+ZBoPG0hMOWqQ6x924kRMEj4bVVm8B_Hw@mail.gmail.com>
 <CANeKSiS_b+cUmJFurFu0s=t+7M5Uh2aL69QZOfViOsKfpN_kag@mail.gmail.com>
 <CANaX5nfM8AZmCsvFB7C_Bbx_jQdtgTLaKYi+_JrdFv7ki=_53Q@mail.gmail.com>
Subject: Re: [PHP-DEV] Renaming PhpAttribute to Attribute
From: ben@benramsey.com (Ben Ramsey)

--Apple-Mail=_1030FD48-7F7B-480F-884C-39CEAC46E4AA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

> Davey Shafik wrote:
>=20
>> I believe that using the PHP namespace is the right way to go, and =
look
>> forward to seeing code like this in the future:
>>=20
>> <?php
>> namespace Dshafik;
>>=20
>> use PHP\Attribute;
>>=20
>> <<Attribute>>
>> class Foo { }


> Chase Peeler wrote:
>=20
>> I don't think PhpAttribute is a bad name [...] nor is it logically =
inconsistent with other Php* named classes.


> Rowan Tommins wrote:
>=20
>> One of the things I dislike about "PhpAttribute" is that it's still =
really generic - I know I'm writing PHP, so it feels like broken =
Hungarian notation ("class FooClass extends BarInterface") rather than =
an actual name.


I=E2=80=99ve been trying to think through other naming schemes that =
could set a good precedent for these discussions as we move forward, =
since I think this will continue to be a topic of discussion.

So, I tried to think of alternate schemes, such as introducing a =
root-level attributes namespace (e.g. `Attributes\Attribute` and =
`Attributes\CompilerAttribute`, or `PhpAttributes\Attribute`, etc.), but =
that would see arbitrary namespaces proliferate in the core, and the =
potential for collisions with userland code would be even greater.

I=E2=80=99m starting to come around to Davey=E2=80=99s way of thinking =
here, but I don=E2=80=99t know if I=E2=80=99m quite there yet.

Perhaps we change `PhpCompilerAttribute` to `CompilerAttribute` and =
rename `Attribute`/`PhpAttribute` to `UserlandAttribute`? It seems =
that=E2=80=99s the distinction we=E2=80=99re attempting to make with =
these names.

Cheers,
Ben

--Apple-Mail=_1030FD48-7F7B-480F-884C-39CEAC46E4AA
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iHUEAREIAB0WIQToXQMR3fpbrPOmEOewLZeYnIwHGwUCXq2qZgAKCRCwLZeYnIwH
GxZyAP9jQozGfErotTm/Sh0HRtZS04MClLfxC2VqOZ4QaqEorwD+Mv1jjsO5/X/m
wn9tKtgSDzxqPBcE34nfdyEPD+Jk2T4=
=vnHl
-----END PGP SIGNATURE-----

--Apple-Mail=_1030FD48-7F7B-480F-884C-39CEAC46E4AA--