Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109953
Message-ID: <647703CF-1015-4FBF-868F-8E3525706A43@benramsey.com>
Content-Type: multipart/signed;
	boundary="Apple-Mail=_0776B4DD-81C3-4B6A-855F-CC2953371BAE";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
Date: Fri, 1 May 2020 10:02:06 -0500
In-Reply-To: <CAPNm5sMWF=XOe-H_erfSm0jPerAxKGnXENetbbH+BUZDi+yiiw@mail.gmail.com>
Cc: internals@lists.php.net
To: Max D <max@bukrek.net>
References: <CAPNm5sMWF=XOe-H_erfSm0jPerAxKGnXENetbbH+BUZDi+yiiw@mail.gmail.com>
Subject: Re: [PHP-DEV] Simplify classes syntax proposal
From: ben@benramsey.com (Ben Ramsey)

--Apple-Mail=_0776B4DD-81C3-4B6A-855F-CC2953371BAE
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

> On May 1, 2020, at 09:44, Max D <max@bukrek.net> wrote:
>=20
> Greetings, Internals!
>=20
> This is my first try to input the proposal, please don't be strict )
>=20
> All the years with PHP I hate writing classes. The need to prefix =
EVERY
> property and method use looks horrible and writes horrible. So, the
> proposal:
>=20
> Lets introduce directive
> declare(simple_classes=3D1);
>=20
> This directive will switch interpreter mode, where class declared
> properties and methods are accessible as regular variables and =
functions at
> class code.
>=20
> So, such a fragment
>=20
> public function __construct() {
>   $this->get =3D $this->clean($_GET);
>   $this->post =3D $this->clean($_POST);
>   $this->request =3D $this->clean($_REQUEST);
>   $this->cookie =3D $this->clean($_COOKIE);
>   $this->files =3D $this->clean($_FILES);
>   $this->server =3D $this->clean($_SERVER);
> }
>=20
> will look so with the proposed directive:
>=20
> public function __construct() {
>   $get =3D clean($_GET);
>   $post =3D clean($_POST);
>   $request =3D clean($_REQUEST);
>   $cookie =3D clean($_COOKIE);
>   $files =3D clean($_FILES);
>   $server =3D clean($_SERVER);
> }
>=20
> What do we lose with such an approach? The ability to use local =
variables
> named as class properties and the ability to call regular functions, =
called
> as class methods. Both things are super-rarely used and programmers =
have
> the ability to change naming to achieve them.
>=20
> For static properties/methods, dynamic ones will have an advantage if
> naming matches.
> Of course, the ability to use usual prefixes will be preserved.
>=20
> I'm not going to implement this, hoping someone will volunteer if the
> reaction is positive.
> Also I have some more proposals I will post if this one goes nice.
>=20
> With best regards,
> MaxD


Hi, MaxD!

Is there a particular problem you=E2=80=99re trying to solve with this =
proposal? You say, =E2=80=9CAll the years with PHP I hate writing =
classes. The need to prefix EVERY property and method use looks horrible =
and writes horrible.=E2=80=9D

I=E2=80=99m generally in favor of changes that make it easier for =
developers to do their jobs well, but I don=E2=80=99t think writing =
`$this->` in front of property and method names is a detriment to the =
development process. In fact, I think it aids in writing safe code. =
Without `$this->`, it=E2=80=99s possible to unknowingly use or overwrite =
a class property, when that is not the intent. I think this leads to a =
poor developer experience, so I would be against this change.

Cheers,
Ben




--Apple-Mail=_0776B4DD-81C3-4B6A-855F-CC2953371BAE
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iHUEAREIAB0WIQToXQMR3fpbrPOmEOewLZeYnIwHGwUCXqw57gAKCRCwLZeYnIwH
G2XJAP4wr0yLinDl1DvDRLVH3yEIYBUYgGoJp2VdWDQ5MZlz2wEAkZF85nt3VqsB
zNaCuWcj50jaXtuL7EJbYWa2EEFek4g=
=k8JJ
-----END PGP SIGNATURE-----

--Apple-Mail=_0776B4DD-81C3-4B6A-855F-CC2953371BAE--