Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109931
MIME-Version: 1.0
References: <CANeKSiRbPFbP9GjWdwbQ3J4oLP2wjKGoxnz1EbVb9K0aejg4EQ@mail.gmail.com>
 <CADyq6sLw8tKcqV0ukjbkey5tXEraTk6zzbbTXB8_0_wO0xO6jQ@mail.gmail.com>
 <CANeKSiQJuMkF0Hyc+8GDoUVc_MNs_xtt+y97qv+LMuOCAtotEQ@mail.gmail.com>
 <4063585.LhOdPkFbeG@mcmic-probook> <CANeKSiRq4GDwHEk8Jyxf8LmC2V0Aqdeouki+BytxwShzJ1KaFQ@mail.gmail.com>
 <CAPKYkKzkUt=TerFmn+ZBoPG0hMOWqQ6x924kRMEj4bVVm8B_Hw@mail.gmail.com>
In-Reply-To: <CAPKYkKzkUt=TerFmn+ZBoPG0hMOWqQ6x924kRMEj4bVVm8B_Hw@mail.gmail.com>
Date: Wed, 29 Apr 2020 18:24:05 +0300
Message-ID: <CANeKSiS_b+cUmJFurFu0s=t+7M5Uh2aL69QZOfViOsKfpN_kag@mail.gmail.com>
To: Chase Peeler <chasepeeler@gmail.com>
Cc: =?UTF-8?Q?C=C3=B4me_Chilliet?= <come.chilliet@fusiondirectory.org>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b45d7305a46f8a9e"
Subject: Re: [PHP-DEV] Renaming PhpAttribute to Attribute
From: benas.molis.iml@gmail.com (Benas IML)

--000000000000b45d7305a46f8a9e
Content-Type: text/plain; charset="UTF-8"

Hello,

> Again, your assumption that just about everyone uses namespaced classes
> doesn't take into account closed source projects. I don't care if it's a
major
> release or not - BC breaks should always be avoided without a major
benefit

With an introduction of any new language construct, function, class or
constant, we don't know whether it affects closed source projects and we
can't.
So using your own logic, you can't assume that closed source projects use
`Attribute` either.

Another key term to take into consideration from my email is "in such cases
isn't the first priority". That doesn't mean it doesn't matter, so please
don't
change my words as you please. Since PHP has global namespace reserved,
things
like implementation details matter much more **in such cases**.

> str_contains adds functionality to PHP. We aren't debating whether to add
> attribute functionality to PHP, but what to call it. As such, this
argument is
> an invalid comparison.

What I meant by `str_contains()` was its name. There were multiple PHP
projects
that offered a global helper function called `str_contains()`. As such,
introduction of this function was also a name clash for them.

> As I said above, I'm ambivalent about this particular issue. However, I
get
> nervous when I start to see the "Who cares if it breaks stuff" or "Well,
they
> shouldn't be doing it that way, so screw them" arguments pop up. While the
> chances of a BC break might be minimal using "Attribute" - I don't think
that
> PhpAttribute is an undue burden in an attempt to avoid such instances,
nor is
> it logically inconsistent with other Php* named classes.

Well then you shouldn't take everything so "harshly" and as a debate. There
are
no "arguments" here, I am simply expressing my own opinion.

As for naming inconsistencies, Rowan addressed that already.

Best regards,
Benas Seliuginas.

--000000000000b45d7305a46f8a9e--