Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:109930 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 25193 invoked from network); 29 Apr 2020 16:36:42 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 29 Apr 2020 16:36:42 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id E6FF31804F4 for ; Wed, 29 Apr 2020 08:10:05 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 29 Apr 2020 08:10:05 -0700 (PDT) Received: by mail-wr1-f48.google.com with SMTP id d17so2942113wrg.11 for ; Wed, 29 Apr 2020 08:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=HNp00mNrA2K/S7vdV8MBcMDvKifuSdfpwZPqFjtHPY0=; b=Zr4D07gRzg2t2x85HamarOM9e9gv8bgmc8zBUHJyHXYd1Bjwviq4rx3anWgbbs1njC XLoLWV8Rir/kpmcwhqP3Hn7pt4mKzoovUA3cZ9vLrxF6QKnr2O2wTq7OVk288z3beW6K lItCb6ewEHC/gX7/M9fT9LGoGhf5rhRFtSHE4NByW9F25WrSa5v4GyrKbN/fA2pJXk6t JBExsxzcgWQl0R9hRBF4NNiLQCQLVLGDPOC7hM0eGu9tFstpMiGV6gir58LAxMAIK424 RGAFXZkJPMsmXr/GefilEzXjboVTT+VBt9eaHDAZKf0BLGj5vRiuo08fqHAp6furP2RD bpAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=HNp00mNrA2K/S7vdV8MBcMDvKifuSdfpwZPqFjtHPY0=; b=fdT39EUttxMmIzY9t99rVx0O3C9uqv+5jdSUybTg/zSEUZGyIJHRTptYbgfkaA8IhZ QfDlbaM9ehYXlp9UD3jZ++ZgTJRb0sHwBNemwrNaOCBpHU1GLFufbZVm25har79+Ei9G wgkXiWw6+SGJg1vOCxenmZ9W7fqY0wSEqKWKMtwoBFC14BrYEHrjFQvHe3CMMdh9sjh8 gYrueq/bg4LjILGVwvWDA5+l8QWgSeh6IDDd1PUZ29gDmVk+E6bG2Ab+d404vlaVheNZ vbXrm8qEGMetNtQFw+TfxtEWgwxFn3ARR5kzmH/GvIdJjk4svve9ix9xRl1/xD0azGk8 IpiA== X-Gm-Message-State: AGi0PuapQmS1uDNRpNPx0kt0zGjl+h7i3QxL29b3BVFNN4E2vF4xA587 hHPpPQW1NBu0YfulTEfDilJka2XV X-Google-Smtp-Source: APiQypLRX1We49+7eQk4nCQ6LjE0iM134Gr171v9m+AqOySsHq95a082U8xwjNePdtSA9qZA8DE5zA== X-Received: by 2002:a5d:54d0:: with SMTP id x16mr38117177wrv.86.1588173003922; Wed, 29 Apr 2020 08:10:03 -0700 (PDT) Received: from [192.168.0.14] (cpc84253-brig22-2-0-cust114.3-3.cable.virginm.net. [81.108.141.115]) by smtp.googlemail.com with ESMTPSA id n131sm8748263wmf.35.2020.04.29.08.10.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2020 08:10:03 -0700 (PDT) To: internals@lists.php.net References: <4063585.LhOdPkFbeG@mcmic-probook> Message-ID: <02f30c98-9091-c0e4-c185-cd578b060a3a@gmail.com> Date: Wed, 29 Apr 2020 16:10:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [PHP-DEV] Renaming PhpAttribute to Attribute From: rowan.collins@gmail.com (Rowan Tommins) On 29/04/2020 15:41, Chase Peeler wrote: > I don't think PhpAttribute is a bad name [...] nor is it logically inconsistent with other Php* named classes. One of the things I dislike about "PhpAttribute" is that it's still really generic - I know I'm writing PHP, so it feels like broken Hungarian notation ("class FooClass extends BarInterface") rather than an actual name. As for "other Php* named classes", as far as I know, we have exactly one, PhpToken, and that's not even in any released version yet. Possibly that name is also poor, and it should be renamed "ParserToken" or "PhpSourceToken", but at least it can be read as "a token of PHP". As I was writing my last message, I looked for examples of other very generic classes that we've added to core, and came upon "Error". Like "Attribute", that's an extremely common term, with meanings in various contexts. If "PhpAttribute" means "an attribute applied to PHP code", then "an error thrown by the PHP engine" ought to be "PhpError", but I don't remember that name even being suggested. So, if we do think "Attribute" is too generic a name, perhaps someone can suggest a better one, rather than just sticking the letters "PHP" in front. Regards, -- Rowan Tommins (né Collins) [IMSoP]