Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109902
MIME-Version: 1.0
References: <CANeKSiRbPFbP9GjWdwbQ3J4oLP2wjKGoxnz1EbVb9K0aejg4EQ@mail.gmail.com>
In-Reply-To: <CANeKSiRbPFbP9GjWdwbQ3J4oLP2wjKGoxnz1EbVb9K0aejg4EQ@mail.gmail.com>
Date: Wed, 29 Apr 2020 07:51:46 +0200
Message-ID: <CANUQDCgqjhepuNb5yxqyJU43WfwOZx-h6BLSmp66Eij855LZwA@mail.gmail.com>
To: Benas IML <benas.molis.iml@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Renaming PhpAttribute to Attribute
From: me@kelunik.com (Niklas Keller)

Hey Benas,

I've also tried to get that change into the original RFC, but wasn't able to.

I'm in favor of an amendment RFC to change the name to Attribute.

Best,
Niklas

Am Di., 28. Apr. 2020 um 17:37 Uhr schrieb Benas IML
<benas.molis.iml@gmail.com>:
>
> Hey internals,
>
> Since it's safe to say that the Attributes v2 RFC has passed, I wanted to
> make a separate thread based on the comment by Rowan Tommins in the PHP
> namespace policy thread. This is a quote from his comment:
>
> > One prefix doesn't make a trend. "PhpToken" is a different case - it's a
> > token of PHP source code, so the prefix isn't anything to do with
> > avoiding name collisions, it's a natural clarification.
> >
> > To be honest, I'd be perfectly happy with the attributes RFC using the
> > class name "Attribute", just as we use "Iterator", "Closure",
> > "Exception", etc, etc. At which point the whole thing's a non-issue.
>
> I do strongly agree with him and I believe we should rename `\PhpAttribute`
> to simply `\Attribute` before the PHP 8 release in order to improve
> consistency with other classes and interfaces e. g. Iterator, ArrayAccess,
> Countable. It would also make the attribute class definition look more
> aesthetically pleasing:
>
> ```
> <?php
> <<Attribute>>
> class Test {}
> ```
>
> I am ready to make an RFC for this if the replies are mostly positive, so
> please, express your opinions!
>
> Best regards,
> Benas Seliuginas
> P.S: this is my second email account so hopefully it won't get marked as
> spam.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>