Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109899
MIME-Version: 1.0
References: <CAPyj-LDo0AafB9FZoxUHU35Y7PAU+DYb4qGm+KV2-eF5KvNmng@mail.gmail.com>
 <CA+kxMuRo-oVGYCuFRsB8mag=x6W57Yy0CmY6rXeRQ55pKqLsew@mail.gmail.com>
 <5ea6e4b0.1c69fb81.cf3ee.2bbfSMTPIN_ADDED_MISSING@mx.google.com>
 <CAF+90c8LGLRz5zkNKAQ=c5SiR-ig5hh_HHWQXaS2JAeMG85-Eg@mail.gmail.com>
 <CAPyj-LDGip777McwcuVGMm--UryD0r_U4A-NJP60w74sVsKpRg@mail.gmail.com>
 <CALKiJKq1EX5Zdw2a12=FESd8=yFqtuDt7ofovR0vLov8=ztVAg@mail.gmail.com>
 <VI1PR02MB47035BF9579880C7FDB470F3E2AC0@VI1PR02MB4703.eurprd02.prod.outlook.com>
 <CALKiJKpEOb7Txvq5n7k9=1ga-sdPoZG3xWjiWxJSCaNpoiGzjg@mail.gmail.com> <969c6150-a084-48c0-ae8f-b8043dce321d@www.fastmail.com>
In-Reply-To: <969c6150-a084-48c0-ae8f-b8043dce321d@www.fastmail.com>
Reply-To: Levi Morrison <levi.morrison@datadoghq.com>
Date: Tue, 28 Apr 2020 18:37:36 -0600
Message-ID: <CAAKU0unX1YKrP90K6f4sR+_Nn-Oz5GSgc2+fn1-zQ6LHMEiObw@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [VOTE] match expression
From: internals@lists.php.net ("Levi Morrison via internals")

> One issue that was discussed a few weeks ago, and led to the current synt=
ax, was too many variations within the switch syntax; of course, trying to =
do it all in one syntax is perpetuating that problem.  However, I think Row=
an has suggested a syntax that may be sufficiently self-documenting.  To wi=
t, independent of rustmatch (above):
>
> switch ($foo) {
>   case 1: {
>     Many statements here.
>   }
>   case 2: {
>     Many statements here.
>   }
> }
>
> The curly braces are already understood by most PHPers to mean "a block o=
f statements", and so it's a logical jump in this case.  As Rowan suggests,=
 the {} imply a break.  To keep it simple we should probably not allow mixi=
ng and matching in a single switch.  Either list-style (break required) or =
{}-style (break implied).
>
> That handles break;

Sadly, it doesn't. That code is valid today:

    <?php
    $foo =3D 1;
    switch ($foo) {
        case 1: {
            echo "1\n";
        }
        case 2: {
            echo "2\n";
        }
    }
    ?>

Which outputs:
1
2