Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109887
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
In-Reply-To: <CANeKSiRbPFbP9GjWdwbQ3J4oLP2wjKGoxnz1EbVb9K0aejg4EQ@mail.gmail.com>
Date: Tue, 28 Apr 2020 11:20:46 -0500
Cc: internals@lists.php.net
Content-Transfer-Encoding: quoted-printable
Message-ID: <CEC3F0C9-3651-400F-82B2-F35E0AEC955C@trowski.com>
References: <CANeKSiRbPFbP9GjWdwbQ3J4oLP2wjKGoxnz1EbVb9K0aejg4EQ@mail.gmail.com>
To: Benas IML <benas.molis.iml@gmail.com>
Subject: Re: [PHP-DEV] Renaming PhpAttribute to Attribute
From: aaron@trowski.com (Aaron Piotrowski)


> On Apr 28, 2020, at 10:37 AM, Benas IML <benas.molis.iml@gmail.com> =
wrote:
>=20
> Hey internals,
>=20
> Since it's safe to say that the Attributes v2 RFC has passed, I wanted =
to
> make a separate thread based on the comment by Rowan Tommins in the =
PHP
> namespace policy thread. This is a quote from his comment:
>=20
>> One prefix doesn't make a trend. "PhpToken" is a different case - =
it's a
>> token of PHP source code, so the prefix isn't anything to do with
>> avoiding name collisions, it's a natural clarification.
>>=20
>> To be honest, I'd be perfectly happy with the attributes RFC using =
the
>> class name "Attribute", just as we use "Iterator", "Closure",
>> "Exception", etc, etc. At which point the whole thing's a non-issue.
>=20
> I do strongly agree with him and I believe we should rename =
`\PhpAttribute`
> to simply `\Attribute` before the PHP 8 release in order to improve
> consistency with other classes and interfaces e. g. Iterator, =
ArrayAccess,
> Countable. It would also make the attribute class definition look more
> aesthetically pleasing:
>=20
> ```
> <?php
> <<Attribute>>
> class Test {}
> ```
>=20
> I am ready to make an RFC for this if the replies are mostly positive, =
so
> please, express your opinions!
>=20
> Best regards,
> Benas Seliuginas
> P.S: this is my second email account so hopefully it won't get marked =
as
> spam.
>=20
> --=20
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>=20


I too strongly agree that attributes should use `Attribute` over =
`PhpAttribute` or even `PHP\Attribute`.

Namespaces for bundled classes probably should be used in the future, =
but for logically grouped classes (such as DOM), extensions, etc.

Attributes are a basic language feature, and therefore should live in =
the global namespace the same way as Throwable, Iterator, Countable, =
etc.

I did not want naming to be a blocker on the attributes RFC, but it =
certainly bothered me that it was not `<<Attribute>>`.

Please put together an RFC for this name change, I would definitely vote =
yes.

Regards,
Aaron Piotrowski