Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:109884 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 84731 invoked from network); 28 Apr 2020 17:26:22 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 28 Apr 2020 17:26:22 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 093E21804D0 for ; Tue, 28 Apr 2020 08:59:36 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 28 Apr 2020 08:59:35 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id l11so17351730lfc.5 for ; Tue, 28 Apr 2020 08:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wyp8PX2A5DVRo7xlP7CH9OvpicHICkUiHJDL0VE8geU=; b=FVlIvbsGoSiO+pjwXFEpB+nIe+4gql06pPFzai8MmeN5ZBDpmmYUvCV85U+NJNEjx2 3vx2uMnOXC2iqmyzorL4KkGiBsbZHDTlF/NEVcedN2w8A+ZVMiQWFw6bESpgyZslcKCd uz/lE/B/t+pvC7i8+1SoDpWrftXJ2l4qdU1nFwKSfos82ADn/IP+PqPDljOpkf+gdKEz 3F8D01HKn51EjMySD80ddq+g9YzN05i+Cqq6i4z98Tp0FZHOwzDAMPrb523fwaMmq8qH w6dYEkg9DO/JqZFVCKCRXOT1jhrD28sNjz6C8y5yA09jTPYdZO+w3blKMGjka0Nx4VKG Asgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wyp8PX2A5DVRo7xlP7CH9OvpicHICkUiHJDL0VE8geU=; b=Nu8avvC++RAJEJBD7ZkDJcw566s22PgjkDKRgfmgBs3J+lz9WGhxcqf8aQKdbv9Yic AU13dBYKaLQUHsuIhB0GsQWpWqznjH0ATxRP+mcF1lMJ9E1NlUMWPtKvfDFEQeITDWcM F6DxL+6ZZnbvN2ffSSpi4cn9oG50EuxCIszL9y5AoHIFkYMtq06ukXUjCp7oHfvxR6q2 IUKQ8wVtc2lHCd1uARn6QA0OnWOqB35M9Ioco//g8yupHLiZGyXVkTYveemxOiox2G4N XuSSZBRrK739sR2ZEOeJNsWcXJZr9PNNiAsD01GUzNQKDQQDbASFVkNoICby7asA8Teq EZIg== X-Gm-Message-State: AGi0Pua3mGaEs1pf9v2U1EcQIB3wugjEZxIN1BJ4NiP6IKRRZJFXl5sN kwynZAy9twIe5zA2DN6grUQwdj2lx4i+R/aIx9I= X-Google-Smtp-Source: APiQypLaMovpj6ZnKSDBVtJqcypBZX7tpQGLGTEi/ypO7afhp2DlDoGSo4IVKA/BohWFN5Cq953NUXemmyKRKe2OkNE= X-Received: by 2002:a19:9141:: with SMTP id y1mr19340365lfj.168.1588089574081; Tue, 28 Apr 2020 08:59:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Tue, 28 Apr 2020 18:59:22 +0300 Message-ID: To: Marco Pivetta Cc: PHP Internals List Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] Renaming PhpAttribute to Attribute From: benas.molis.iml@gmail.com (Benas IML) Hello, > `Attribute` is certainly too generic, and will needlessly collide with code > in the wild. Could you provide any examples as to where '\Attribute' is being used in the wild? I haven't seen a single project that has an Attribute class and uses the global namespace. > I suggest circling back to the `PHP\` namespace discussion, and having > `PHP\Attribute` if you really have a problem with current naming. In regards to `\PHP` namespace, I believe this is future scope and because it's still not voted into PHP, we should do the things like we always did. I believe that the reasoning behind calling the attribute's class as `PhpAttribute` was because the author wanted to be consistent with PhpToken. But since `PhpToken` was called as such to not raise ambiguity to what kind of a token it is, I believe that the attribute class should be simply named `Attribute` instead. Best regards, Benas Seliuginas