Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109883
MIME-Version: 1.0
References: <CAF+90c8tW27-rhrk8pLieMsEWa4WHEBciPX1zThME68zf6s2QQ@mail.gmail.com>
 <CAF+90c_8CEBr90C_Y5Ze9uPL=aMis8Lzh2vKX4=Ac_y7ioQMcw@mail.gmail.com>
 <CAOWwgpntdhGd-avcJrO-X3Yiq=WG5uf5jrpH-VXQda_fGip05w@mail.gmail.com> <CAPyj-LBPsXzRzWp3Mn26pTJc=XJyWsnD_TK1J5h8mnu-b6TPSw@mail.gmail.com>
In-Reply-To: <CAPyj-LBPsXzRzWp3Mn26pTJc=XJyWsnD_TK1J5h8mnu-b6TPSw@mail.gmail.com>
Date: Tue, 28 Apr 2020 17:56:11 +0200
Message-ID: <CAOWwgpndYuRYs8EgBxWUwktmCrdSVuHxBiT4-i+vYUCdKGUdPw@mail.gmail.com>
To: Ilija Tovilo <tovilo.ilija@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000a96a0c05a45bdf5b"
Subject: Re: [PHP-DEV] Re: [RFC] Constructor Property Promotion
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--000000000000a96a0c05a45bdf5b
Content-Type: text/plain; charset="UTF-8"

>
> > I would expect attributes to apply only to the properties on my side.
>
> Parameter annotations could be interesting for dependency injection.
> Symfony currently has some DI magic through parameter names among
> other things. It might be nice to control these through annotations
> instead. This would be impossible or involve a lot of hackery and
> assumptions if the annotations aren't available on the parameters.
> Alternatively we might make this information available through
> reflection (like ReflectionParameter::getGeneratedProperty()) so you
> can look for the annotation there.
>

Sure, this could be considered.

But this doesn't contradict what I wrote:
if one uses constructor promotion, the then attributes should only go to
the properties to me.
If one wants to add attributes to parameters, then one would need to
opt-out from constructor promotion.

Nicolas

--000000000000a96a0c05a45bdf5b--