Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109880
MIME-Version: 1.0
Date: Tue, 28 Apr 2020 18:37:39 +0300
Message-ID: <CANeKSiRbPFbP9GjWdwbQ3J4oLP2wjKGoxnz1EbVb9K0aejg4EQ@mail.gmail.com>
To: internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Subject: Renaming PhpAttribute to Attribute
From: benas.molis.iml@gmail.com (Benas IML)

Hey internals,

Since it's safe to say that the Attributes v2 RFC has passed, I wanted to
make a separate thread based on the comment by Rowan Tommins in the PHP
namespace policy thread. This is a quote from his comment:

> One prefix doesn't make a trend. "PhpToken" is a different case - it's a
> token of PHP source code, so the prefix isn't anything to do with
> avoiding name collisions, it's a natural clarification.
>
> To be honest, I'd be perfectly happy with the attributes RFC using the
> class name "Attribute", just as we use "Iterator", "Closure",
> "Exception", etc, etc. At which point the whole thing's a non-issue.

I do strongly agree with him and I believe we should rename `\PhpAttribute`
to simply `\Attribute` before the PHP 8 release in order to improve
consistency with other classes and interfaces e. g. Iterator, ArrayAccess,
Countable. It would also make the attribute class definition look more
aesthetically pleasing:

```
<?php
<<Attribute>>
class Test {}
```

I am ready to make an RFC for this if the replies are mostly positive, so
please, express your opinions!

Best regards,
Benas Seliuginas
P.S: this is my second email account so hopefully it won't get marked as
spam.