Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109846
To: Ilija Tovilo <tovilo.ilija@gmail.com>, PHP internals
	<internals@lists.php.net>
Thread-Topic: [PHP-DEV] [VOTE] match expression
Thread-Index: AQHWGu3mJQmypaMm7k6DfmqkncjvDqiJ5rEP
Date: Sat, 25 Apr 2020 15:35:10 +0000
Message-ID:
 <DM6PR07MB6618864E9E06F8BDB1878D16F9D10@DM6PR07MB6618.namprd07.prod.outlook.com>
References:
 <CAPyj-LDo0AafB9FZoxUHU35Y7PAU+DYb4qGm+KV2-eF5KvNmng@mail.gmail.com>
In-Reply-To:
 <CAPyj-LDo0AafB9FZoxUHU35Y7PAU+DYb4qGm+KV2-eF5KvNmng@mail.gmail.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [2RORL8bt8DIxuRD9ll2sh3YL7be2CUDN]
x-ms-publictraffictype: Email
x-incomingheadercount: 45
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: d163c8e3-c66b-4f11-bc60-08d7e92e3d6b
x-ms-traffictypediagnostic: MW2NAM12HT246:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 LUJIYbEQdbpJIKqsxnXBiAEe1KaGHpdV8Jk2EK+n+5YiZ/+20RjaKI8ae7f5Ho0LCjghhxGHDyHpWvKf5ieNT1ly5b2rFELa7mLXGKwnlJZO5to5G9K5uZLC7nC/ewtlu3MKR7dy8TqSmfNysx3xo+VZErH+hLubIPHNIjneguu4gEudK2gVQRTcPeTV7qzayeHGiM0w3Fd7h4rpWBsHAuETWofXHYQtFZkE82xe2UtXUDoFUaBzzKzHK0B+uMgM
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR07MB6618.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901;
x-ms-exchange-antispam-messagedata:
 cdS08RgD+/8iWKX7Mn+CWTwAD65OWMKE2qzQcehqsMqgAdYqcjc/bHpN4fxKDBSXTVUg4rP0Ul/sTWGkUpeBdk6aU3pmM//NUSGuK3P3gcPmdrdAn7SfA63zB45/zZVYrBYEtLpVqim3gLZ2RoZxOQ==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: d163c8e3-c66b-4f11-bc60-08d7e92e3d6b
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2020 15:35:10.3583
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM12HT246
Subject: Re: [PHP-DEV] [VOTE] match expression
From: tysonandre775@hotmail.com (tyson andre)

Hi Ilija,=0A=
=0A=
1. I was confused by the vote announcement email about what "block statemen=
ts" meant - https://github.com/php/php-src/pull/5371#discussion_r415079802=
=0A=
=0A=
> Thus I have decided to move block expressions to a separate RFC. =0A=
=0A=
This is clarified in https://wiki.php.net/rfc/match_expression#blocks =0A=
=0A=
> **For the time being using blocks in match expressions that use the retur=
n value in any way results in a compilation error:**=0A=
=0A=
(I personally agree with that change for this RFC introducing `match`)=0A=
=0A=
2. As Dan Ackroyd mentioned, https://wiki.php.net/rfc/howto mentions:=0A=
=0A=
> When discussion ends, and a minimum period of two weeks has passed since =
you mailed internals@lists.php.net in step 4,=0A=
> consider one day heads up mail on the mailing list and then you can move =
your RFC to =93Voting=94 status.=0A=
=0A=
Other people may read the guidelines differently from me,=0A=
and I've made small mistakes with the process in the past due to not rememb=
ering everything in the howto.=0A=
(and they're guidelines instead of rules)=0A=
In the future, I'd recommend:=0A=
=0A=
i. After finalizing the changes to the RFC and before starting the vote, em=
ail out a summary of what changed on the RFC discussion thread itself=0A=
   (https://externals.io/message/109590 "[DISCUSSION] Match expression")=0A=
ii. Consider waiting at least 24 hours before starting the vote, extending =
it if you made more changes to the RFC or implementation.=0A=
   This would give voters a clearer idea of what was being voted on, and gi=
ve people time to point out issues/blockers/new questions with the new RFC/=
implementation (if needed).=0A=
=0A=
P.S. Although it's obvious voting has started, and some other RFCs kept the=
 title "Proposed Voting Choices",=0A=
https://wiki.php.net/rfc/match_expression#proposed_voting_choices could be =
renamed from "Proposed Voting Choices" to "Vote"=0A=
=0A=
Thanks,=0A=
- Tyson=