Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109811
MIME-Version: 1.0
References: <CAP=4hC+9duSVcREvwOD3jZv+5fmqQzzR=UEraw4Yr6P+b+FfaQ@mail.gmail.com>
 <90F4B395-F010-4196-9C40-7896D4F3F2F4@gmail.com> <CAP=4hC+moKGF-XyGuaYEzc54tJb++5bUxCpF-8vXxsPS+NHuUw@mail.gmail.com>
 <CAP=4hCLH9PrkQxuF=m154jA2+d56eTXTfmtsCfjxOcBiR4pmsw@mail.gmail.com>
 <CAP=4hCLLY5THWuR1h-hiTQ4sW0Nb1Wv1+EYcSBhmaTYU6x7MOg@mail.gmail.com>
 <CAOWwgpmXfzDw4yWUEme_DtuiMitZf6vqYVm57F_nxYAAHPyORA@mail.gmail.com>
 <CAP=4hC+cxqXp-TLUUeRWg0q5=Bzi5dXMr_N7ypfVjTywP6zF1Q@mail.gmail.com>
 <CAOWwgpmK8Zzk4+LAnSFW0nTCR8qEaFG4AD_97zoDqvA7wh6kyA@mail.gmail.com>
 <0A374409-6FA6-4E02-A7E6-EACA3E42451C@gmail.com> <CAF+90c8wKkaT_2NdeHB0VOUmBnAEfaKsBDbaOEa1s8Z_arPyPA@mail.gmail.com>
 <436FD800-A316-4C99-8793-C6EF4BD15BE3@gmail.com> <CAF+90c8uO2KcO8t=syX+4GMMda62K6gsfpW+FCC22VVNLv+_Jw@mail.gmail.com>
 <DM6PR07MB66183F8C032ACF82F6E96E32F9D80@DM6PR07MB6618.namprd07.prod.outlook.com>
In-Reply-To: <DM6PR07MB66183F8C032ACF82F6E96E32F9D80@DM6PR07MB6618.namprd07.prod.outlook.com>
Date: Thu, 23 Apr 2020 16:07:58 +0200
Message-ID: <CAP=4hC+935iYw7daPLh0nmwm4ACCmT9p5=KMWPEDgMNCT3XcKA@mail.gmail.com>
To: tyson andre <tysonandre775@hotmail.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, Claude Pache <claude.pache@gmail.com>, 
	Nicolas Grekas <nicolas.grekas+php@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000004e16b805a3f5c7a2"
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] Ensure correct magic methods'
 signatures when typed
From: carusogabriel34@gmail.com (Gabriel Caruso)

--0000000000004e16b805a3f5c7a2
Content-Type: text/plain; charset="UTF-8"

On Thu, 16 Apr 2020 at 18:46, tyson andre <tysonandre775@hotmail.com> wrote:

> > Ah, so that's what this is about! In that case, I'd be happy to simply
> > always enforce that __construct() cannot return a value, in the same way
> we
> > do for ": void" functions. (If we have backwards compatibility concerns,
> we
> > can add this as a warning instead of hard error.)
>
> I'd approve of that. It'd also be useful to enforce that __construct and
> other magic methods aren't generators,
> and that methods from traits renamed to __construct have the same
> restrictions.
>
> ```
> php > class X{ public function __construct() { yield 2; }}
> php > new X();  // nonsense
> php > trait T1 { public function f() { echo "In f\n"; return 2; }}
> php > class Z { use T1{ f as __construct; } }
> php > new Z();
> In f
> ```
>
> - Tyson


Hello Tyson,

This falls under the `Future Scope`  of the RFC (
https://wiki.php.net/rfc/magic-methods-signature#future-scope) as checking
for the actual return value of these magic methods would be a larger BC.

For now, only the signatures will be checked.

--0000000000004e16b805a3f5c7a2--