Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109631
MIME-Version: 1.0
References: <CAEPJdunSr8PkBtSLO8g_JMLzM4cFVnXsQSEMFmu2RN25XT=grw@mail.gmail.com>
 <CAEPJdumF8GaAqLj+=gNi-dMP1GYSvk_DYJuy3gG0N5J1vSXRqQ@mail.gmail.com> <CAOWwgpkgMYLbVNj9Tohc=uw26c0VKA2mk2fC5Tm1cyYRv+BrOg@mail.gmail.com>
In-Reply-To: <CAOWwgpkgMYLbVNj9Tohc=uw26c0VKA2mk2fC5Tm1cyYRv+BrOg@mail.gmail.com>
Date: Tue, 14 Apr 2020 16:03:07 +0200
Message-ID: <CAEPJdukmYN20bMKCXhP8oAuX0geHEsae1CxvGp5LYS2b5fRXhg@mail.gmail.com>
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>
Cc: PHP Internals <internals@lists.php.net>, 
	=?UTF-8?Q?Martin_Schr=C3=B6der?= <m.schroeder2007@googlemail.com>
Content-Type: multipart/alternative; boundary="000000000000649ed805a340a98f"
Subject: Re: [PHP-DEV] Re: [RFC] Attributes v2
From: kontakt@beberlei.de (Benjamin Eberlei)

--000000000000649ed805a340a98f
Content-Type: text/plain; charset="UTF-8"

On Tue, Apr 14, 2020 at 3:04 PM Nicolas Grekas <nicolas.grekas+php@gmail.com>
wrote:

> Hi Benjamin,
>
> I have updated the RFC with much of the feedback received here, on Twitter
>> and Reddit.
>>
>> https://wiki.php.net/rfc/attributes_v2
>
>
> Thanks for the update and for giving this a try!
>
> I'm wondering about nested annotations: as you know, they're quite common
> in apps that use doctrine/annotation.
> How do you think these should be migrated to the new system?
>

Nested attributes are not supported in this step, because they might
interfere with potential changes to constant AST. Tyson dipped into that
topic a few weeks ago.

If constants were to allow something like const $foo = new Foo(); - then
this would automatically be available for attributes (they use the same
concept).

For now I suppose the approach would be to flatten the attributes, for
example:

@JoinTable(name="users_posts", joinColumns={@JoinColumn(name="id",
referencedColumnName="user_id"}, inverseJoinColumns={@JoinColumn(name="id",
"referencedColumnName="post_id"})

becomes:

<<JoinTable("users_posts")>>
<<JoinColumn("id", "user_id")>>
<<InverseJoinColumn("id", "post_id")>>

As you can see with this example, named arguments is another under
construction area in the language that would automatically spill its
benefits to attributes.

Think of this like scalar types in 7.0 that missed nullable, which was
added in 7.1.


> Nicolas
>

--000000000000649ed805a340a98f--