Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109600
MIME-Version: 1.0
References: <CAPyj-LDfdATXFD+dc5AY9EqWWxgf8LP1joD2fzvm==1gUoN35A@mail.gmail.com>
 <4d5a347b-8d9d-43fd-b811-3cb6c13ad06a@www.fastmail.com>
In-Reply-To: <4d5a347b-8d9d-43fd-b811-3cb6c13ad06a@www.fastmail.com>
Date: Sun, 12 Apr 2020 22:39:20 +0200
Message-ID: <CAPyj-LAYqL-Mqji_bZCO53Z1jF5ebBkjCKd8TYuRcTWGxeGrEA@mail.gmail.com>
To: php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [DISCUSSION] Match expression
From: tovilo.ilija@gmail.com (Ilija Tovilo)

Hi Larry

> That not only alleviates the need to support multi-line blocks, it keeps =
the match statement itself clearer to understand at-a-glance, and encourage=
s the definition of named, testable, small blocks of code (ie, functions wh=
ether anonymous or not), which is a net win on its own.

I'm generally not a fan of this approach. I think it's unrealistic to
expect users to move code into a separate function just because it
takes two lines of code instead of one. People can't be forced into
writing clean code and my fear here is that they will just revert back
to using what is more convenient.

> I'm fine with match() always being strict comparison, regardless of the t=
ype mode. However, it should probably be made more explicit in the RFC that=
 it is unaffected by the type mode.

That's a good point, I will add it to the RFC.

> Possible addition: Make the match input optional, defaulting to "true".

This has been proposed before. I do like it but I'm not sure if other peopl=
e do.

> I would strongly recommend removing the block statement support, as it ju=
st muddies the water.

As mentioned in my e-mail to Rowan, we'll probably never agree on this
point. At the end of the day, you might be getting a feature you don't
have to use. It barely adds any complexity to the language but will
make other users happy.

Thanks for you input!

Ilija