Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109592
MIME-Version: 1.0
References: <CAPyj-LDfdATXFD+dc5AY9EqWWxgf8LP1joD2fzvm==1gUoN35A@mail.gmail.com>
 <CAFPFaM+7Lpe3VVhgAT_yL8d0c-s8cVbvjEJ6Qi8QX40PmopyRQ@mail.gmail.com>
In-Reply-To: <CAFPFaM+7Lpe3VVhgAT_yL8d0c-s8cVbvjEJ6Qi8QX40PmopyRQ@mail.gmail.com>
Date: Sun, 12 Apr 2020 11:48:22 +0200
Message-ID: <CAPyj-LCmsQPPPfabwXh84cFhpP_A-f_5=4bTYnc4qB6mLbKQWw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [DISCUSSION] Match expression
From: tovilo.ilija@gmail.com (Ilija Tovilo)

Hi George

I appreciate your feedback.

> One small decision that I personally disagree with is the usage of `=>` compared to using the colon as the switch statement does.

I picked the `=>` symbol because IMO the extra spacing and wider
symbol visually separates the two sides better. The difference isn't
huge, I don't have a strong preference either way.

> Also, combining this with less/greater or equal than binary operators makes for a rather confusing line in my eyes.

I guess that depends on the lhs. For example, using the ternary
operator has the opposite effect.

```
match (true) {
    // =>
    $cond ? $foo : $bar => $val, // Better
    $val >= 42 => $val, // Worse

    // :
    $cond ? $foo : $bar: $val, // Worse
    $val >= 42: $val, // Better
}
```

Regards,
Ilija