Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109577
MIME-Version: 1.0
References: <CAF+90c8cB8qj75xtH=E_00SH+XmD9=aEMkq+26Rt2Qf=L0scPA@mail.gmail.com>
 <CAF+90c_151GW13aNAeQzQZpHkdHgbo5S-_P8eNfd9qA8OywyVA@mail.gmail.com>
In-Reply-To: <CAF+90c_151GW13aNAeQzQZpHkdHgbo5S-_P8eNfd9qA8OywyVA@mail.gmail.com>
Date: Thu, 9 Apr 2020 11:50:27 +0200
Message-ID: <CAC5V6gg2O2EqArvUjr_Svw5X3RyZ1yJnKnWFPV2BotEDC=n1jA@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Re: [RFC] Allow trailing comma in parameter lists
From: guilliam.xavier@gmail.com (Guilliam Xavier)

On Thu, Apr 9, 2020 at 10:02 AM Nikita Popov <nikita.ppv@gmail.com> wrote:
>
> On Thu, Mar 26, 2020 at 7:52 PM Nikita Popov <nikita.ppv@gmail.com> wrote:
>
> > Hi internals,
> >
> > This has been declined in the past, but I just keep making this mistake,
> > and believe it deserves reconsideration...
> >
> > https://wiki.php.net/rfc/trailing_comma_in_parameter_list
> >
>
> Heads up: I plan to move this to voting tomorrow. Don't think there's much
> to discuss here...
>
> Nikita

Hello Nikita,

I'm personally favorable, but since some concern has been raised that
it *might* be interpreted as "encouraging" functions with many
parameters (and I fear that could be taken as a motive for voting
"no"), I would just suggest (again) that you could add an example (or
even replace the current one) of a function with only two/three
parameters that would still exceed 120 columns if on a single line
(with e.g. descriptive names, [union] type declarations for parameters
and/or return, and/or a class constant as default value for the last
parameter, that's not so uncommon)... Just my two cents ;)

Best regards,

-- 
Guilliam Xavier