Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:109567 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 98563 invoked from network); 8 Apr 2020 15:09:41 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 8 Apr 2020 15:09:41 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id A4FAE1804C4 for ; Wed, 8 Apr 2020 06:37:52 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS30827 82.113.144.0/21 X-Spam-Virus: No X-Envelope-From: Received: from xdebug.org (xdebug.org [82.113.146.227]) by php-smtp4.php.net (Postfix) with ESMTP for ; Wed, 8 Apr 2020 06:37:52 -0700 (PDT) Received: from localhost (localhost [IPv6:::1]) by xdebug.org (Postfix) with ESMTPS id BA5A210C75F; Wed, 8 Apr 2020 14:37:50 +0100 (BST) Date: Wed, 8 Apr 2020 14:37:50 +0100 (BST) X-X-Sender: derick@singlemalt.home.derickrethans.nl To: Sherif Ramadan cc: Benjamin Morel , Andrea Faulds , PHP Internals In-Reply-To: Message-ID: References: <5e87a7aa.1c69fb81.2e0a2.74daSMTPIN_ADDED_MISSING@mx.google.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Change var_export() array syntax touse short hand arrays From: derick@php.net (Derick Rethans) On Wed, 8 Apr 2020, Sherif Ramadan wrote: > On Wed, Apr 8, 2020 at 9:22 AM Benjamin Morel > wrote: > > > > VAR_EXPORT_NO_INDEX > > > > Note that I wouldn't consider a BC break to change var_export()'s > > behaviour to always discard indexes when they're numeric, I'm not > > sure this should even be an option! > > > > > Well, it might if people are testing the output of var_export(), like in > the phpt tests. I wouldn't have considered the short array syntax a BC > break either if it weren't for that little pot hole. It's different. Changing from long to short array syntax makes it unparsable by older versions of PHP. I still believe that none of these options are needed. var_export() has been added to generate PHP parser readable code. And these options are extra complexity adds no new functionality. cheers, Derick -- PHP 7.4 Release Manager Host of PHP Internals News: https://phpinternals.news Like Xdebug? Consider supporting me: https://xdebug.org/support https://derickrethans.nl | https://xdebug.org | https://dram.io twitter: @derickr and @xdebug