Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109564
MIME-Version: 1.0
References: <CAL+t6cFeiGzLbfaQB0o2JKSx1OdfYYbY+k6QTG0V3H344XbCEA@mail.gmail.com>
 <CAG9XoMTHn6-Cu47w5PdFb4oYFtRYQahB72ZgNxVsEYWdjyTv8g@mail.gmail.com>
 <CAESVnVoCLJUosHkvbd7xV-a+4CDB7CpCMp+Az=dhVCAqS_63mw@mail.gmail.com>
 <CAG9XoMTfB0W+3g_1FiGnBvKsVi8++N9adpAodAw-9NDyjSs4LA@mail.gmail.com>
 <CAESVnVrPWQ119DV5j_zQAsA_6s3AwEQu=jfasBavOD1vs+mC0w@mail.gmail.com>
 <CAG9XoMRtiOTijwtg-RviUCdszhEoB7WUPSzWNRsTgrFkvrHwwg@mail.gmail.com>
 <CAESVnVpXQO6hhjHFa6gwyfXi-_N4mEwYCCiDGf-5b7X1YUdtYg@mail.gmail.com>
 <CAPKYkKy68bGCWuChqFBw0zRnaDF8c=Wmv-c8UVyd5B5jkGdHTA@mail.gmail.com>
 <CAESVnVqFiVLYF4HapY4qxpXhJrJyexeK1t7dBmZ4cFzuNHHeBQ@mail.gmail.com>
 <5e87a7aa.1c69fb81.2e0a2.74daSMTPIN_ADDED_MISSING@mx.google.com> <CAL+t6cEBm_3nhceX6yuNQDYyOfZd6KZky54C_qAzZjiyvxnyQQ@mail.gmail.com>
In-Reply-To: <CAL+t6cEBm_3nhceX6yuNQDYyOfZd6KZky54C_qAzZjiyvxnyQQ@mail.gmail.com>
Date: Wed, 8 Apr 2020 09:12:09 -0400
Message-ID: <CAL+t6cFp7TrH4YU=9zFQCyA+qKSRNUjg9TnQf4i3GSTVDNCJ9g@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000019f75205a2c740c3"
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] Change var_export() array syntax
 touse short hand arrays
From: theanomaly.is@gmail.com (Sherif Ramadan)

--00000000000019f75205a2c740c3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

So to recap on what's been discussed so far, because I plan to bring this
to a vote next week...

I am updating the RFC to reflect that the change will no longer break
backwards compatibility. I will be adding an flags argument with the
following 3 optional bitwise flags for var_export:

- VAR_EXPORT_SHORT_ARRAY [Triggers short-array syntax]
- VAR_EXPORT_NO_INDEX [Discards numbered indexes in arrays (only if they
are sequential from 0)]
- VAR_EXPORT_NO_WHITESPACE [For one-liners]

This complicates the implementation slightly, but I think it brings a
greater net-benefit.

On Fri, Apr 3, 2020 at 5:19 PM Sherif Ramadan <theanomaly.is@gmail.com>
wrote:

>
>
> On Fri, Apr 3, 2020 at 5:16 PM Andrea Faulds <ajf@ajf.me> wrote:
>
>> Hey Sara,
>>
>> Sara Golemon wrote:
>> > On Mon, Mar 30, 2020 at 12:38 PM Chase Peeler <chasepeeler@gmail.com>
>> wrote:
>> >
>> >> Just out of curiosity, is there any reason we couldn't add an optiona=
l
>> >> parameter called "$short_array" or whatever that defaults to false?
>> Then
>> >> there shouldn't be any backwards compatibility issues.
>> >>
>> >> None at all, though I'd make it an `int $options =3D 0` similar to
>> > json_encode().  I'd have a FAR easier time supporting that than a
>> wholesale
>> > BC break for the sake of breaking BC.
>> >
>> > I can think of a few options:
>> >    VAR_EXPORT_SHORT_ARRAY =3D> use [] instead of arrray()
>> >    VAR_EXPORT_NO_WHITESPACE =3D> Keep it concise, single line
>> >    VAR_EXPORT_NO_VECTOR_INDEX =3D> If an array is vector-like, skip
>> indexes
>> >    VAR_EXPORT_UTF8_UESCAPE =3D> Detect places where we can use \u{1234=
}
>> syntax
>> > for UTF8 strings
>> >
>> > Though I'm going to stay with my stated position that I would MUCH
>> rather
>> > this stuff live in userspace.  Just because PHP's penchant for
>> > including the kitchen sink is broken already doesn't mean we should
>> break
>> > it more.
>>
>>
> +1 for me
>
>
>> As you say, including the kitchen sink might be excessive, but I think
>> adding a $flags option isn't a bad idea =E2=80=94 it's low-maintenance, =
simple
>> to implement and, in my opinion, would be frequently used. We can have
>> the best of both worlds: consistent default behaviour, and nicer output
>> for those who want it. I can see myself using VAR_EXPORT_SHORT_ARRAY and
>> VAR_EXPORT_NO_VECTOR_INDEX (not with that name=E2=80=A6) :)
>>
>
> *Fingers crossed*
>
>
>> (Also, if we make the output of var_export() more palatable, will people
>> use it instead of print_r() for development purposes? I can dream=E2=80=
=A6)
>>
>> Thanks,
>> Andrea
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>

--00000000000019f75205a2c740c3--