Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109562
MIME-Version: 1.0
References: <CAF+90c8tW27-rhrk8pLieMsEWa4WHEBciPX1zThME68zf6s2QQ@mail.gmail.com>
In-Reply-To: <CAF+90c8tW27-rhrk8pLieMsEWa4WHEBciPX1zThME68zf6s2QQ@mail.gmail.com>
Date: Wed, 8 Apr 2020 13:56:43 +0200
Message-ID: <CAOWwgpnTyNquJAESjhT8Kq7=BYNOres0AXrAXibNAdrAf9g=Bg@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005ad09505a2c632bc"
Subject: Re: [PHP-DEV] [RFC] Constructor Property Promotion
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--0000000000005ad09505a2c632bc
Content-Type: text/plain; charset="UTF-8"

> I would like to submit the following RFC for your consideration:
> https://wiki.php.net/rfc/constructor_promotion
>

I love it :)

Just one question:
Shouldn't default values be copied on the signature? That would be expected
for me.
(and that would make the properties still initialized when child classes
don't call the parent constructor for whatever reasons.)

class Point {
    public function __construct(
        public float $x = 0.0,

<==>

class Point {
    public float $x = 0.0;

    public function __construct(
        float $x = 0.0,

Nicolas

--0000000000005ad09505a2c632bc--