Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109547
Message-ID: <90F4B395-F010-4196-9C40-7896D4F3F2F4@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_30FF7173-581F-499D-A308-72BDC1F52307"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
Date: Tue, 7 Apr 2020 12:55:56 +0200
In-Reply-To: <CAP=4hC+9duSVcREvwOD3jZv+5fmqQzzR=UEraw4Yr6P+b+FfaQ@mail.gmail.com>
Cc: PHP Internals <internals@lists.php.net>
To: Gabriel Caruso <carusogabriel34@gmail.com>
References: <CAP=4hC+9duSVcREvwOD3jZv+5fmqQzzR=UEraw4Yr6P+b+FfaQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] Ensure correct magic methods'
 signatures when typed
From: claude.pache@gmail.com (Claude Pache)

--Apple-Mail=_30FF7173-581F-499D-A308-72BDC1F52307
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> Le 5 avr. 2020 =C3=A0 16:01, Gabriel Caruso =
<carusogabriel34@gmail.com> a =C3=A9crit :
>=20
> Hello, internals.
>=20
> Hereby you can find the RFC Document that I want to discuss as =
suggested
> via https://externals.io/message/109416 and
> https://externals.io/message/107990:
>=20
> https://wiki.php.net/rfc/magic-methods-signature
>=20
> Best regards,
>=20
> -- Gabriel Caruso


Hi,

Regarding __construct(), etc. Since those methods are not supposed to =
return anything, they ought to accept the `void` return pseudo-type in =
their signature, which means exactly that: =E2=80=9Cdo not return =
anything=E2=80=9D. I consider that the current behaviour (i.e., not =
accepting the `: void` signature) as a bug, and was very surprised when =
I stumbled on it.

------------

Also, I raise the following question:

Should omitted types be added implicitly? I.e., if I write:  `function =
__toString() { }` should the compiler interpret it as `function =
__toString(): string { }` ? (Currently, it is not the case.)=20

Doing so would raise BC concerns for some, uh, creative uses of magic =
methods. On the other hand, that may help to add progressively type =
informations on magic methods, since there is no need to synchronise =
manually classes and subclasses (the compiler would do it automatically =
for you). Concrete example here: https://3v4l.org/hTMvA =
<https://3v4l.org/hTMvA>=20

=E2=80=94Claude


--Apple-Mail=_30FF7173-581F-499D-A308-72BDC1F52307--