Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109534
MIME-Version: 1.0
References: <CAPyj-LB_RwOd7u02HipKb=iWuF-kMSr0=k=Ecd7eZFtxhz-GxQ@mail.gmail.com>
 <CA+kxMuT_xdUvquseU9PXGuGxt6gY9F+kUaeVnK0BaS8zU+FWNw@mail.gmail.com>
In-Reply-To: <CA+kxMuT_xdUvquseU9PXGuGxt6gY9F+kUaeVnK0BaS8zU+FWNw@mail.gmail.com>
Date: Sun, 5 Apr 2020 12:53:15 +0200
Message-ID: <CAPyj-LDtDbWXiJCNrBuUTkPmermN99FaHbsYOiNLWxNtHar6rw@mail.gmail.com>
To: Dan Ackroyd <Danack@basereality.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [VOTE] throw expression
From: tovilo.ilija@gmail.com (Ilija Tovilo)

Hi Dan

> Did the RFC get updated to address this?
>
> As the current behaviour listed* in the RFC seems wrong and surprising to=
 me.

I did respond to that e-mail but probably got classified as spam as
were the other e-mails I sent with that address. This was my response:

> I've thought about this some more. There is a reasonable way to recognize=
 this, namely to check if the expression after the throw keyword is of type=
 ZEND_AST_OR or ZEND_AST_AND. The expression above will fail with this mess=
age (given that $condition is false):
>
> > Fatal error: Uncaught Error: Can only throw objects in ...
>
> IMO this is clear enough that a message for this edge case is not necessa=
ry.

We could improve the error message by printing the type that got
passed to throw:

> Fatal error: Uncaught Error: Can only throw objects, bool given in ...

Regards,
Ilija