Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109527
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
In-Reply-To: <CAF+90c9Nu=dnsVFJk4c7uYxkrqDeARtKe91Mu2Pxb7mTP_Y9dQ@mail.gmail.com>
Date: Sat, 4 Apr 2020 03:51:16 -0400
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <48A06F96-14FE-430C-8894-9D8545126522@newclarity.net>
References: <CAF+90c8tW27-rhrk8pLieMsEWa4WHEBciPX1zThME68zf6s2QQ@mail.gmail.com>
 <5cb01a17-ff6d-b072-30d3-6a891dcc5434@fischer.name>
 <CAF+90c-TnF0in1LUjaFwePjT_tL92X9jcp6VKD5qZvJgckaxMQ@mail.gmail.com>
 <90a167b7-a848-1a95-9255-862239509283@fischer.name>
 <CAF+90c9Nu=dnsVFJk4c7uYxkrqDeARtKe91Mu2Pxb7mTP_Y9dQ@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Subject: [PHP-DEV] [RFC] Parse errors w/Constructor Property Promotion?
From: mike@newclarity.net (Mike Schinkel)

Question: Will parse errors in the __construct() be reported as all =
being on the same line, or will the parser report each as a distinct =
line of code when reporting parse errors?


-Mike


> On Apr 2, 2020, at 9:52 AM, Nikita Popov <nikita.ppv@gmail.com> wrote:
>=20
> On Thu, Apr 2, 2020 at 3:47 PM Markus Fischer <markus@fischer.name> =
wrote:
>=20
>> Him
>>=20
>> On 02.04.20 12:07, Nikita Popov wrote:
>>> Reflection will see the state after desugaring. That is, it just =
sees
>>> normal properties and normal constructor args. I've made this more
>> explicit
>>> in the RFC now:
>> https://wiki.php.net/rfc/constructor_promotion#reflection
>>=20
>> Thanks!
>>=20
>> Another one, also related a bit to your PHP-Parser (?): will the
>> tokenization process "see" the code before desugaring?
>>=20
>> I'm wondering how automated translation tool can detect that a =
certain
>> code is not "sugared" and promote this?
>>=20
>=20
> Tokenization and parsing both happen before the desugaring, they see =
the
> code in its original form. They would detect promoted properties by
> checking whether a constructor parameter has a visibility modifier.  =
Of
> course, tooling might want to perform the desugaring transformation
> internally, so it sees a uniform representation of everything.
>=20
> Regards,
> Nikita