Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109521
User-Agent: Cyrus-JMAP/3.1.7-1082-g13d7805-fmstable-20200403v1
Mime-Version: 1.0
Message-ID: <0c3c5e36-629c-4ce3-9d3b-e742cde438de@www.fastmail.com>
In-Reply-To: 
 <CAC5V6ghASJDCyCwk2b-yL4fHoDZ4cQ-hCtFmU8tE2OkuDUAZEg@mail.gmail.com>
References: 
 <CAF+90c8cB8qj75xtH=E_00SH+XmD9=aEMkq+26Rt2Qf=L0scPA@mail.gmail.com>
 <a8205b8b-1e6a-138b-3e62-4556b51ce758@gmail.com>
 <CAJmjfvVmXFjC82WqLaB-oL+LAJRjbsejVF8teSCmBBTNSCLckQ@mail.gmail.com>
 <CAC5V6ghASJDCyCwk2b-yL4fHoDZ4cQ-hCtFmU8tE2OkuDUAZEg@mail.gmail.com>
Date: Fri, 03 Apr 2020 11:28:33 -0500
Reply-To: "Ryan McCullagh" <me@ryanmccullagh.com>
To: "PHP internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] [RFC] Allow trailing comma in parameter lists
From: internals@lists.php.net ("Ryan McCullagh via internals")

This would make PHP more consistent. Please add this!

On Mon, Mar 30, 2020, at 12:32 PM, Guilliam Xavier wrote:
> On Sun, Mar 29, 2020 at 11:31 PM Jakob Givoni <jakob@givoni.dk> wrote:
> >
> > Hi Rowan,
> >
> > On Sat, Mar 28, 2020 at 4:01 PM Rowan Tommins <rowan.collins@gmail.com> wrote:
> > >
> > > While I'd personally be fine with this change, I think we should
> > > understand why the previous proposal failed rather than just hoping the
> > > vote goes differently this time.
> >
> > I think you have a good point here.
> > I've only been around for a short time so I can't comment on historical reasons.
> > And though I agree the proposal is logical and consistent, I have this
> > nagging feeling in the back of my brain:
> > Are we encouraging functions with long lists of parameters so that
> > they need to be on their own lines?
> 
> Just to say, with descriptive names and type declarations (and now
> union types), even a method with just two or three parameters can need
> to be wrapped to keep lines below 120 characters ;) Maybe the RFC
> could include an example?
> 
> But I am curious too about why it failed last time.
> 
> -- 
> Guilliam Xavier
> 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
> 
>