Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:10952 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 3184 invoked by uid 1010); 7 Jul 2004 17:30:19 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 3134 invoked from network); 7 Jul 2004 17:30:19 -0000 Received: from unknown (HELO mail.zend.com) (80.74.107.235) by pb1.pair.com with SMTP; 7 Jul 2004 17:30:19 -0000 Received: (qmail 20433 invoked from network); 7 Jul 2004 17:30:18 -0000 Received: from localhost (HELO zeev-laptop-new.zend.com) (127.0.0.1) by localhost with SMTP; 7 Jul 2004 17:30:18 -0000 Message-ID: <5.1.0.14.2.20040707202714.05228788@localhost> X-Sender: zeev@localhost X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Wed, 07 Jul 2004 20:30:16 +0300 To: "Rob Richards" Cc: "Marcus Boerger" , In-Reply-To: <00e101c46426$dfbf0830$f7dea8c0@cyberware.local> References: <01db01c46342$2ea393c0$f7dea8c0@cyberware.local> <11610112416.20040706204401@marcus-boerger.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] extended objects with read_property and get_property_ptr_ptr From: zeev@zend.com (Zeev Suraski) At 16:32 07/07/2004, Rob Richards wrote: >Attached is a patch for zend_execute.c which will fall to read_property if >get_property_ptr_ptr returns NULL in zend_fetch_property_address_inner. >Hopefully this is the correct fix as it didnt break any tests and resolves >the issue I hit. It's not a correct fix :I get_ptr_ptr must return the address of an allocated zval *, one which can later be separated, etc. T(result->u.var).var.ptr doesn't fall into that category - it can be gone in the next opcode... The only safe way to return a zval ** is for the underlying object model to implement get_ptr_ptr... Zeev