Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109515
MIME-Version: 1.0
References: <CAF+90c8tW27-rhrk8pLieMsEWa4WHEBciPX1zThME68zf6s2QQ@mail.gmail.com>
 <5cb01a17-ff6d-b072-30d3-6a891dcc5434@fischer.name> <CAF+90c-TnF0in1LUjaFwePjT_tL92X9jcp6VKD5qZvJgckaxMQ@mail.gmail.com>
 <90a167b7-a848-1a95-9255-862239509283@fischer.name>
In-Reply-To: <90a167b7-a848-1a95-9255-862239509283@fischer.name>
Date: Thu, 2 Apr 2020 15:52:13 +0200
Message-ID: <CAF+90c9Nu=dnsVFJk4c7uYxkrqDeARtKe91Mu2Pxb7mTP_Y9dQ@mail.gmail.com>
To: Markus Fischer <markus@fischer.name>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009f4cb605a24f1c38"
Subject: Re: [PHP-DEV] [RFC] Constructor Property Promotion
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000009f4cb605a24f1c38
Content-Type: text/plain; charset="UTF-8"

On Thu, Apr 2, 2020 at 3:47 PM Markus Fischer <markus@fischer.name> wrote:

> Him
>
> On 02.04.20 12:07, Nikita Popov wrote:
> > Reflection will see the state after desugaring. That is, it just sees
> > normal properties and normal constructor args. I've made this more
> explicit
> > in the RFC now:
> https://wiki.php.net/rfc/constructor_promotion#reflection
>
> Thanks!
>
> Another one, also related a bit to your PHP-Parser (?): will the
> tokenization process "see" the code before desugaring?
>
> I'm wondering how automated translation tool can detect that a certain
> code is not "sugared" and promote this?
>

Tokenization and parsing both happen before the desugaring, they see the
code in its original form. They would detect promoted properties by
checking whether a constructor parameter has a visibility modifier.  Of
course, tooling might want to perform the desugaring transformation
internally, so it sees a uniform representation of everything.

Regards,
Nikita

--0000000000009f4cb605a24f1c38--