Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109507
MIME-Version: 1.0
References: <003701d6013c$9afe9750$d0fbc5f0$@gmx.de> <7a83f950a31d94d5ff2307ac8219db3b7b6482b6.camel@schlueters.de>
 <CANZOY=Cre6iCUskSWoic1D22s197b553i+tp5hBK_iuiFo_=cA@mail.gmail.com>
 <12ad7c71-8958-7742-12c4-e83e359c8186@gmx.de> <3B71F74D-8142-48FB-9660-835B08D1DDDD@schlueters.de>
 <705aba69-8c17-f882-19fd-6f41a2c2ca25@gmx.de> <07f176a5c2ff0338cb67c9755bf37af6dcc2d465.camel@schlueters.de>
 <CAF+90c_w=igQi3skmiOKeJ+t=BjRTmM-7u=-SOpj_ri+gxZ08Q@mail.gmail.com>
 <BD01F8AF-C8EA-4F41-9208-0F4169886AA2@schlueters.de> <5e7fbf46.1c69fb81.9d100.8efeSMTPIN_ADDED_MISSING@mx.google.com>
In-Reply-To: <5e7fbf46.1c69fb81.9d100.8efeSMTPIN_ADDED_MISSING@mx.google.com>
Date: Thu, 2 Apr 2020 12:31:10 +0200
Message-ID: <CAF+90c-5uNbD5KLLsSwKozpFDQJO9DsQxvRhpgvkheHneaAGAA@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009d460b05a24c4da3"
Subject: Re: [PHP-DEV] [VOTE] Userspace operator overloading
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000009d460b05a24c4da3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 28, 2020 at 10:19 PM Andrea Faulds <ajf@ajf.me> wrote:

> Hi everyone,
>
> Johannes Schl=C3=BCter wrote:
> >
> > If we use two methods as well it is a saner design. I won't like it, bu=
t
> lot better than the current one.
>
> Just want to +1 this. Two methods, neither of which are static, seems
> like a cleaner approach to me. I maybe like this better than my
> suggested boolean argument (it certainly looks nicer).
>
> Consider what happens in the current proposal if a class, intentionally
> or otherwise, only supports being on one side of an operator=E2=80=A6 it =
will
> produce the same error message as if it didn't support the overload at
> all :(


Could you please expand on what the advantage of using two instance methods
over one static method is? As far as I can tell, Python uses this design
because they don't really have static methods (let's gloss over the
@staticmethod decorator here), so it's basically their only choice.

I don't buy your error message argument. Assuming
https://wiki.php.net/rfc/arithmetic_operator_type_checks passes, the error
you're going to get is something like "Unsupported operand types: int /
Vector", which seems reasonable to me, and leaves potential support for
"Vector / int" open.

The presence of only one of the two method could not be used for the error
message anyway, because presence of the method does not imply actual
support of the type combination, and we certainly wouldn't want to do a
call for the reverse order to adjust the error message.

Regards,
Nikita

--0000000000009d460b05a24c4da3--