Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109464
MIME-Version: 1.0
References: <CAF+90c8cB8qj75xtH=E_00SH+XmD9=aEMkq+26Rt2Qf=L0scPA@mail.gmail.com>
 <a8205b8b-1e6a-138b-3e62-4556b51ce758@gmail.com> <CAJmjfvVmXFjC82WqLaB-oL+LAJRjbsejVF8teSCmBBTNSCLckQ@mail.gmail.com>
In-Reply-To: <CAJmjfvVmXFjC82WqLaB-oL+LAJRjbsejVF8teSCmBBTNSCLckQ@mail.gmail.com>
Date: Mon, 30 Mar 2020 19:32:51 +0200
Message-ID: <CAC5V6ghASJDCyCwk2b-yL4fHoDZ4cQ-hCtFmU8tE2OkuDUAZEg@mail.gmail.com>
To: Jakob Givoni <jakob@givoni.dk>
Cc: Rowan Tommins <rowan.collins@gmail.com>, php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] Allow trailing comma in parameter lists
From: guilliam.xavier@gmail.com (Guilliam Xavier)

On Sun, Mar 29, 2020 at 11:31 PM Jakob Givoni <jakob@givoni.dk> wrote:
>
> Hi Rowan,
>
> On Sat, Mar 28, 2020 at 4:01 PM Rowan Tommins <rowan.collins@gmail.com> wrote:
> >
> > While I'd personally be fine with this change, I think we should
> > understand why the previous proposal failed rather than just hoping the
> > vote goes differently this time.
>
> I think you have a good point here.
> I've only been around for a short time so I can't comment on historical reasons.
> And though I agree the proposal is logical and consistent, I have this
> nagging feeling in the back of my brain:
> Are we encouraging functions with long lists of parameters so that
> they need to be on their own lines?

Just to say, with descriptive names and type declarations (and now
union types), even a method with just two or three parameters can need
to be wrapped to keep lines below 120 characters ;) Maybe the RFC
could include an example?

But I am curious too about why it failed last time.

-- 
Guilliam Xavier