Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109448
Return-Path: <sebastian@php.net>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 15860 invoked from network); 30 Mar 2020 09:55:59 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 30 Mar 2020 09:55:59 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id 6CDE1180509
	for <internals@lists.php.net>; Mon, 30 Mar 2020 01:21:52 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
	SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2
X-Spam-ASN: AS20694 188.94.24.0/21
X-Spam-Virus: No
X-Envelope-From: <sebastian@php.net>
Received: from scarlet.netpirates.net (scarlet.netpirates.net [188.94.27.5])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Mon, 30 Mar 2020 01:21:51 -0700 (PDT)
Received: from p5de2c3af.dip0.t-ipconnect.de ([93.226.195.175] helo=[192.168.178.42])
	by scarlet.netpirates.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
	(Exim 4.92.3)
	(envelope-from <sebastian@php.net>)
	id 1jIpg6-0004ym-Ix
	for internals@lists.php.net; Mon, 30 Mar 2020 10:21:50 +0200
To: internals@lists.php.net
References: <c608bd11-d005-d176-43c0-59b3c033b66c@php.net>
 <5a797631-3fe1-6440-1d41-29c0ed09fbce@php.net>
 <CADyq6s+hAbnYLVMdaCphhq16vZWJo21Y7E6f7b6crx9XDSre8g@mail.gmail.com>
Reply-To: internals@lists.php.net
Message-ID: <c8497b67-ce76-7d41-3236-07852134c84a@php.net>
Date: Mon, 30 Mar 2020 10:21:50 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <CADyq6s+hAbnYLVMdaCphhq16vZWJo21Y7E6f7b6crx9XDSre8g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Interfaces and ReflectionMethod::isConstructor()
From: sebastian@php.net (Sebastian Bergmann)

Am 30.03.2020 um 10:14 schrieb Marco Pivetta:
> Patch makes a lot of sense, but is it done that way to still support 7.x?
> I'm not sure (don't have a local build of PHP 8.x-dev) if
> https://wiki.php.net/rfc/remove_php4_constructors is going to come in
> effect as "PHP4 constructors are finally gone".

https://github.com/sebastianbergmann/phpunit/commit/8d399fd561a9a227898fb734c9e89fa1b13d75c8 
:-)