Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109446
MIME-Version: 1.0
References: <c608bd11-d005-d176-43c0-59b3c033b66c@php.net> <5a797631-3fe1-6440-1d41-29c0ed09fbce@php.net>
In-Reply-To: <5a797631-3fe1-6440-1d41-29c0ed09fbce@php.net>
Date: Mon, 30 Mar 2020 10:14:56 +0200
Message-ID: <CADyq6s+hAbnYLVMdaCphhq16vZWJo21Y7E6f7b6crx9XDSre8g@mail.gmail.com>
To: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009daebf05a20e0c67"
Subject: Re: [PHP-DEV] Interfaces and ReflectionMethod::isConstructor()
From: ocramius@gmail.com (Marco Pivetta)

--0000000000009daebf05a20e0c67
Content-Type: text/plain; charset="UTF-8"

Hey Sebastian,
<http://ocramius.github.com/>


On Mon, Mar 30, 2020 at 8:45 AM Sebastian Bergmann <sebastian@php.net>
wrote:

> Am 28.03.2020 um 08:44 schrieb Sebastian Bergmann:
> > I can deal with this in PHPUnit's code either way, but need to know what
> > the plan here is.
>
> I worked around the issue now [1].
>
> --
> [1]
>
> https://github.com/sebastianbergmann/phpunit/commit/477798f6b226e830d358bc102cd02bb2e52cfdb2
>

Patch makes a lot of sense, but is it done that way to still support 7.x?
I'm not sure (don't have a local build of PHP 8.x-dev) if
https://wiki.php.net/rfc/remove_php4_constructors is going to come in
effect as "PHP4 constructors are finally gone".

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--0000000000009daebf05a20e0c67--