Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109411
To: internals@lists.php.net
References: <c608bd11-d005-d176-43c0-59b3c033b66c@php.net>
Message-ID: <ab56098f-cc66-b3e3-b1c4-18e016400388@gmx.de>
Date: Sun, 29 Mar 2020 12:45:07 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <c608bd11-d005-d176-43c0-59b3c033b66c@php.net>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: Interfaces and ReflectionMethod::isConstructor()
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 28.03.2020 at 08:44, Sebastian Bergmann wrote:

> I recently received a bug report for PHPUnit [1] that with PHP 8 test
> doubles (test stubs or mock objects) can no longer be created for
> interfaces that declare a constructor.
>
> I was able to reproduce this [2] and learned that PHPUnit's
> canMockMethod() [3] returns a different result on PHP 8 compared to PHP
> 7. This is due to the return value of ReflectionMethod::isConstructor()
> when the ReflectionMethod object was created for an interface.
>
> Here is a minimal, self-contained, reproducing test case:
>
> <?php
> interface I
> {
>     public function __construct();
> }
>
> var_dump((new ReflectionMethod(I::class, '__construct'))->isConstructor(=
));
>
> The code shown above yields the following result:
>
> * bool(true) for PHP 5.0.0 and PHP 5.0.1
> * bool(false) for PHP 5.0.2 through PHP 7.4.4
> * bool(true) for PHP 8.0-dev
>
> I think that the behaviour in PHP 8 (and PHP 5.0.0 and PHP 5.0.1) is
> correct. But I also think that constructor declarations have no place in
> interfaces ... so I am confused. Which is why I did not open a ticket on
> bugs.php.net and bring this topic to this list instead.
>
> To the best of my knowledge, this change in behaviour of isConstructor()
> between PHP 7 and PHP 8 is not yet documented. If it is intentional and
> here to stay then it should be documented.
>
> I can deal with this in PHPUnit's code either way, but need to know what
> the plan here is.

The relevant change[1] is that now the class entry members
serialize_func, unserialize_func, constructor, destructor and clone are
set, if the respective methods are declared on an interface.

[1]
<https://github.com/php/php-src/pull/3846/files#diff-3a8139128d4026ce0cb0c=
86beba4e6b9L5549-R5605>

=2D-
Christoph M. Becker