Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109352
MIME-Version: 1.0
References: <003701d6013c$9afe9750$d0fbc5f0$@gmx.de>
In-Reply-To: <003701d6013c$9afe9750$d0fbc5f0$@gmx.de>
Date: Thu, 26 Mar 2020 20:02:25 +0100
Message-ID: <CABdc3WoH7rBj9P_0mDUWQ=-m87-vqTDgUaj_uBqrpRgv+ed2Nw@mail.gmail.com>
To: jan.h.boehmer@gmx.de
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d3f2d205a1c6a09a"
Subject: Re: [PHP-DEV] [VOTE] Userspace operator overloading
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Brzuchalski?=)

--000000000000d3f2d205a1c6a09a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

pon., 23 mar 2020 o 18:58 <jan.h.boehmer@gmx.de> napisa=C5=82(a):

> Hi internals,
>
> I have opened voting on
> https://wiki.php.net/rfc/userspace_operator_overloading, which allows
> users
> to overload operators in their own classes.
>

I got two comments, a little late but always better than even later.

The first thing is for operator methods when the operation is not supported
I would see simply `return null;` as the right solution
instead of constant, which name no one will remember.

The second thing is notices which are confusing when suggesting to go
and implement overloaded operator method on extension derived classes
like stdClass like below:

Notice: You have to implement the __add function in class stdClass to use
this operator with an object in...

The text of the notice is not documented in the RFC but it is implemented
that way in the patch.
A PHP developer is not likely gonna download the php-src source code,
build environment and go with the ext/standard implementation and start
adding it in C.
The notice in this cases should either be different or not emitted at all.
If the latter then that has to be documented I guess.

Cheers,
--
Micha=C5=82 Brzuchalski

--000000000000d3f2d205a1c6a09a--