Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109334
MIME-Version: 1.0
References: <59e48d22-6d2d-19df-1b4a-cb2e7281ceea@web.de> <CAAKU0uns+y-7qGq_TCaZEQgcjiR-yjUuAyTU7D4j74eGbLFJ3g@mail.gmail.com>
 <127676cc-c86d-bad9-8501-fbd59975d686@web.de>
In-Reply-To: <127676cc-c86d-bad9-8501-fbd59975d686@web.de>
Date: Thu, 26 Mar 2020 12:49:50 +0000
Message-ID: <CALKiJKpCkDFPEYKmDa-4gR+Vz9rXXP4f7wbVcPsn52DDQKN4jQ@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000006f6ef805a1c16c58"
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] Type casting in array destructuring expressions
From: rowan.collins@gmail.com (Rowan Tommins)

--0000000000006f6ef805a1c16c58
Content-Type: text/plain; charset="UTF-8"

On Thu, 26 Mar 2020 at 12:39, Enno Woortmann <enno.woortmann@web.de> wrote:

>
> $handle = fopen('test.csv', 'r');
> while (($data = fgetcsv($handle)) !== false) {
>      [int $id, string $data, int $year] = $data;
>      // do something with the correctly typed variables
> }
>
> The code would trigger a fatal error when strict_types are enabled. With
> strict_types disabled it would behave identically as the currently
> proposed casts.
>


As I mentioned in a previous e-mail, if it followed current strict_types=0
semantics, it would error if the input row was something like
"42,hello,not-a-valid-year".

Following standard cast semantics, that input would instead silently give
you a value of 0 in $year, which is often not what you want.

Regards,
-- 
Rowan Tommins
[IMSoP]

--0000000000006f6ef805a1c16c58--