Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109285
MIME-Version: 1.0
References: <CAF+90c8xHmxy9DL2cdqc3beNquJ=A6z0+RB8ggwZ6v+a1ixFuw@mail.gmail.com>
 <CAF+90c_0tjL3O1FJtWETOPBTYL75Z52pLMUKf1KMUoLcHsHw6A@mail.gmail.com> <42f7af27-7140-4fbd-96c8-5c313f86268d@www.fastmail.com>
In-Reply-To: <42f7af27-7140-4fbd-96c8-5c313f86268d@www.fastmail.com>
Date: Wed, 25 Mar 2020 13:50:51 +0300
Message-ID: <CAEbg-4Zt2UWzE__DuK9GFdQ6nb+H6VdkbBXsc5xje+aSocUP5Q@mail.gmail.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000073589405a1aba6ad"
Subject: Re: [PHP-DEV] Re: [VOTE] Object-based token_get_all() alternative
From: lisachenko.it@gmail.com (Alexander Lisachenko)

--00000000000073589405a1aba6ad
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello, internals team!

I would like to propose to rename the PhpToken::getAll() method into the
PhpToken::tokenize(string $source) or PhpToken::lex(string $source) to use
a more meaningful verb word.

After renaming, it will sound more natural: $tokenStream =3D
PhpToken::tokenize($sourceCode)

Best regards,
Alexander


=D0=BF=D0=BD, 23 =D0=BC=D0=B0=D1=80. 2020 =D0=B3. =D0=B2 19:04, Larry Garfi=
eld <larry@garfieldtech.com>:

> On Mon, Mar 23, 2020, at 9:07 AM, Nikita Popov wrote:
> > On Fri, Mar 6, 2020 at 10:33 AM Nikita Popov <nikita.ppv@gmail.com>
> wrote:
> >
> > > Hi internals,
> > >
> > > I've opened voting on https://wiki.php.net/rfc/token_as_object, which
> > > adds a new object-based interface to the tokenizer. Voting closes on
> > > 2020-03-20.
> > >
> >
> > This RFC has been accepted unanimously, with 47 votes in favor.
> >
> > Based on the additional feedback in this thread, I'll also add a
> > __toString() method that returns the value of $token->text, unless anyo=
ne
> > has objects to that...
> >
> > Regards,
> > Nikita
>
> As long as __toString() is overridable in subclasses, that seems fine to
> me.
>
> --Larry Garfield
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

--00000000000073589405a1aba6ad--