Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109279
MIME-Version: 1.0
References: <CAH5C8xVoH-OmApcSF59eiUZye_aME1xiFs=umXEXLEG+pnjs8Q@mail.gmail.com>
 <CANS-=pdqvmsYXTLHHvm6VSdS+k0_q9QLKYV_oodH+cOEPjK8nw@mail.gmail.com> <CAFPFaMKmrk_94wixE231x155RghR+ta2dmQu=VCccW9xHaNJ7A@mail.gmail.com>
In-Reply-To: <CAFPFaMKmrk_94wixE231x155RghR+ta2dmQu=VCccW9xHaNJ7A@mail.gmail.com>
Date: Tue, 24 Mar 2020 19:59:45 +0100
Message-ID: <CANS-=pcK5kgHtRQxLEGA+4D3Sqm3p1KCeJyz32vvXCYJgj9MGw@mail.gmail.com>
To: "G. P. B." <george.banyard@gmail.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>, 
	PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000006fa1c905a19e5c41"
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] Locale-independent float to string cast
From: kjarli@gmail.com (Lynn)

--0000000000006fa1c905a19e5c41
Content-Type: text/plain; charset="UTF-8"

On Tue, Mar 24, 2020 at 7:41 PM G. P. B. <george.banyard@gmail.com> wrote:

> On Tue, 24 Mar 2020 at 11:03, Lynn <kjarli@gmail.com> wrote:
>
>>  I would like
>> to see a warning of sorts so I can fix this before untested legacy code
>> will seriously break data exports.
>>
>> Regards,
>> Lynn
>>
>
> We are not saying that this won't be prevalent,especially in legacy code,
> however, IMHO, this is not a serious issue as it is only a matter how one
> character is displayed to end users.
>

It's so much more than a character that's being displayed. There are
automated data exports with prices, that will be automatically consumed on
the other side. These kind of changes can seriously break if they were
expected to be localized currency formats. We're talking massive amounts of
data here. I've seen price formats go wrong often and seen them be fixed
even up to a week ago. It's hard to track all usages in a 20 year old code
base.

As much as I love that this can be fixed, I rather not see it fixed at all
if there's no upgrade path available.

Regards,
Lynn

--0000000000006fa1c905a19e5c41--