Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109267
To: Lynn <kjarli@gmail.com>, =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?=
 <kocsismate90@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
References: <CAH5C8xVoH-OmApcSF59eiUZye_aME1xiFs=umXEXLEG+pnjs8Q@mail.gmail.com>
 <CANS-=pdqvmsYXTLHHvm6VSdS+k0_q9QLKYV_oodH+cOEPjK8nw@mail.gmail.com>
Message-ID: <33bafb73-b5d5-0f61-6beb-440d39e4caee@gmx.de>
Date: Tue, 24 Mar 2020 11:53:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <CANS-=pdqvmsYXTLHHvm6VSdS+k0_q9QLKYV_oodH+cOEPjK8nw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] Locale-independent float to string
 cast
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 24.03.2020 at 11:03, Lynn wrote:

>> Outputting floats as strings in locales which change the decimal
>> separator will have a slightly different output. In our opinion, the
>> backward compatibility break won't be serious in practice
>
> In my opinion, this will be huge. I can't trace back where the thousands=
 of
> possible conversions are used in legacy software. There's a variety of
> custom format functions, sprintf implementations, string casts, and
> number_format usages. Would it be possible to trigger a warning or
> deprecation when using a locale that would have a different result from
> what the new result will be? If I'd use a locale that results in `3.5`, =
I
> don't need a warning. If I use a locale that results in `3,5`, I would l=
ike
> to see a warning of sorts so I can fix this before untested legacy code
> will seriously break data exports.

It would certainly be *possible* to raise a warning/notice if a (non
SCCP optimized) float to string conversion would have different results.
 This would have a (small) performance impact though, so I'd would
rather avoid enforcing it (i.e. maybe temporarily introduce an INI
directive for this purpose).

=2D-
Christoph M. Becker