Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109262
MIME-Version: 1.0
References: <CAH5C8xVoH-OmApcSF59eiUZye_aME1xiFs=umXEXLEG+pnjs8Q@mail.gmail.com>
In-Reply-To: <CAH5C8xVoH-OmApcSF59eiUZye_aME1xiFs=umXEXLEG+pnjs8Q@mail.gmail.com>
Date: Tue, 24 Mar 2020 11:03:17 +0100
Message-ID: <CANS-=pdqvmsYXTLHHvm6VSdS+k0_q9QLKYV_oodH+cOEPjK8nw@mail.gmail.com>
To: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d9454e05a196dd36"
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] Locale-independent float to string cast
From: kjarli@gmail.com (Lynn)

--000000000000d9454e05a196dd36
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

This is a great RFC! Just one minor thing.

> Outputting floats as strings in locales which change the decimal
separator will have a slightly different output. In our opinion, the
backward compatibility break won't be serious in practice

In my opinion, this will be huge. I can't trace back where the thousands of
possible conversions are used in legacy software. There's a variety of
custom format functions, sprintf implementations, string casts, and
number_format usages. Would it be possible to trigger a warning or
deprecation when using a locale that would have a different result from
what the new result will be? If I'd use a locale that results in `3.5`, I
don't need a warning. If I use a locale that results in `3,5`, I would like
to see a warning of sorts so I can fix this before untested legacy code
will seriously break data exports.

Regards,
Lynn

On Tue, Mar 24, 2020 at 10:40 AM M=C3=A1t=C3=A9 Kocsis <kocsismate90@gmail.=
com> wrote:

> Hi Internals,
>
> Together with George, I'd like to propose an RFC for a long-standing
> problem PHP has:
> casting floats to string depends on the locale settings. As this behaviou=
r
> is nonsense, and
> because it can cause quite serious problems, we would like to get rid of
> locale-dependence
> in PHP 8.
>
> Please find our RFC at
> https://wiki.php.net/rfc/locale_independent_float_to_string.
>
> Regards,
> George and M=C3=A1t=C3=A9
>

--000000000000d9454e05a196dd36--