Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109206
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
In-Reply-To: <CA+kxMuREXT60g3UyNbXT=pfMFVcoWO+rco5Exft2Pj-vB_30Bw@mail.gmail.com>
Date: Sun, 22 Mar 2020 14:14:51 -0400
Cc: Ilija Tovilo <ilija.tovilo@me.com>,
 PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <D3934DF9-AEF9-48D7-B607-8BE4DB8F0806@newclarity.net>
References: <5BEF8264-4003-4056-A31C-FF8BEE85FED6@me.com>
 <CA+kxMuREXT60g3UyNbXT=pfMFVcoWO+rco5Exft2Pj-vB_30Bw@mail.gmail.com>
To: Dan Ackroyd <Danack@basereality.com>
Subject: Re: [PHP-DEV] [RFC][DISCUSSION] throw expression
From: mike@newclarity.net (Mike Schinkel)

> On Mar 22, 2020, at 1:16 PM, Dan Ackroyd <Danack@basereality.com> =
wrote:
>=20
> On Sun, 22 Mar 2020 at 16:17, Ilija Tovilo <ilija.tovilo@me.com> =
wrote:
>>=20
>> Due to the modest feedback I=E2=80=99d like to move the throw =
expression RFC to =E2=80=9Cunder discussion=E2=80=9D.
>>=20
>> https://wiki.php.net/rfc/throw_expression
>>=20
>=20
> Regarding the example:
>=20
> $condition || throw new Exception('$condition must be truthy')
>  && $condition2 || throw new Exception('$condition2 must be truthy');
>=20
> The "Deprecate left-associative ternary operator"* RFC made it so that
> parentheses are required when ternary operators are nested in
> complicated statements.
>=20
> Would a similar requirement for parentheses around complicated throw
> expressions be a suitable solution to avoid people being surprised by
> the behaviour?
>=20

Why can't you just do this in userland code?

function throwException(Exception $exception) {
	throw $exception;
}

$callable =3D fn() =3D> throwException( new Exception() );

// $value is non-nullable.
$value =3D $nullableValue ?? throwException( new =
InvalidArgumentException() );=20

// $value is truthy.
$value =3D $falsableValue ?: throwException( new =
InvalidArgumentException() );

// $value is only set if the array is not empty.
$value =3D !empty($array)
    ? reset($array)
    : throwException( new InvalidArgumentException() );


-Mike
P.S. I am probably in the vast minority on this list but I would like to =
see fewer places that throw exceptions, not more.=20

I want to deal with errors where they happen, not throw exceptions or =
have to catch them as I have found that I can write much more robust and =
easier to read code when I write without using exceptions. I came to =
this realization because of learning that Go does not endorse exceptions =
and then I learned why they do not which strongly resonated with me. =
After that, I finally felt comfortable saying that "Exceptions seemed =
like a good idea at the time."

I now have a whole slew of classes who only purpose is to wrap PHP =
functions and classes that throw exceptions so I can call them w/o =
having to use try{}catch{}. Instead I use an if() afterwards to check =
and then handle it if there was an error.

One particularizing problematic exception in PHP is with the DataTime =
class. I have found it effectively impossible to create a class that =
extends DateTime without having the potential for an exception to be =
thrown (unless someone knows a way that I do not?)  The potential is =
actually hypothetical, but PhpStorm nonetheless still complains that I =
have not handled exceptions when using that child class.=