Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:109197 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 31251 invoked from network); 22 Mar 2020 00:59:16 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 22 Mar 2020 00:59:16 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id CF8991801FD for ; Sat, 21 Mar 2020 16:23:00 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sat, 21 Mar 2020 16:22:59 -0700 (PDT) Received: by mail-lj1-f172.google.com with SMTP id w1so10534335ljh.5 for ; Sat, 21 Mar 2020 16:22:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=W9YIQhPxw02H1Gj91WtRwCEys+hqZtM9nIDtKcpH1Ao=; b=bjQvEeKMYpwS3hYvoS4JCnsCDFAgQPDWthvbt74vlUpOMOgDqO7VqE8dpFWzyqBBWd EeGliPIDefu3y805HWIkKjAQFM6cTa4G5GvNx3m2gdSmtwQ3LE1/Vyn3tA1oxaX2D6gz JykMugNa/wbkF6m1Y1noeuwhe3BJI1Q7+1O9rMH1SO4/j2GcW24zZEF8ONZYmKcAMa+k MPsRpQ54ZyNGfAFKUYP9DfkdS5JeCR3b8DthbJVZncva2jf/SPR9JzIsO7BCEGTvRHuO wuGUlQegb5qFrKfOo8R+NIXc4XInADeagq9ONAJTYjZza+U8vY2TVEoyGz4xn1SRR0vn BWhg== X-Gm-Message-State: ANhLgQ37SSGxkRO8I2fnU+bQyoTfORDZGx2Trf3SB1/IxFJQNZJ2BTh2 mwJbSB/RCsVqmcIExSqXpmnv0nAD+Nk7qHN037g= X-Google-Smtp-Source: ADFU+vv/B7sMxeb9ni1CjKZDSlWQFmGi9X8JyNdiZDteMPSFxnZ7AXVe3im2MYOhxysZBRXvJu7mu3SQXx6Na3rSmXI= X-Received: by 2002:a05:651c:44a:: with SMTP id g10mr9648339ljg.16.1584832976936; Sat, 21 Mar 2020 16:22:56 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Sat, 21 Mar 2020 18:22:45 -0500 Message-ID: To: Craig Francis Cc: Ben Ramsey , PHP internals Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] [RFC] is_literal() From: jakob@givoni.dk (Jakob Givoni) On Sat, Mar 21, 2020 at 4:58 PM Craig Francis wr= ote: > I'm happy to use a different name; but I should add that is_numeric() isn= 't really a type, there are other functions such as is_writable(), and the = taint extension uses is_tainted(). Right, good points. However, to my logic, whether or not the value was created from a literal is not something you can infer from the value itself, it needs an accompanying flag or something. I'll suggest is_from_literal() as a more precise formulation. > I've talked to Paul Dragoonis and Derick Rethans recently (they both kind= ly did talks at PHP-SW); when I mentioned it to Paul, I was told that's whe= re I should start looking, and that was the correct terminology; and Derick= helped confirm some of these ideas (but we were walking to the pub at the = time). Sounds like you were having fun though :-) > And while I keep trying, I don't know enough about C, or the internals of= PHP. Appreciate the effort.