Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109144
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
In-Reply-To: <c10fcdfb-465c-4516-242c-1a554b0f4e5c@beccati.com>
Date: Thu, 19 Mar 2020 13:25:34 +0100
Cc: Larry Garfield <larry@garfieldtech.com>,
 php internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <FD5F7D0A-7C01-42E1-AA7C-A04E09EEBFEA@cschneid.com>
References: <99c00084-c212-ad23-628e-87f35e2de849@allenjb.me.uk>
 <782751cf-0058-4dae-9f5a-40648a79986d@www.fastmail.com>
 <c10fcdfb-465c-4516-242c-1a554b0f4e5c@beccati.com>
To: Matteo Beccati <php@beccati.com>
Subject: Re: [PHP-DEV] Changing the default PDO error mode
From: cschneid@cschneid.com (Christian Schneider)

Am 19.03.2020 um 10:31 schrieb Matteo Beccati <php@beccati.com>:
> On 14/03/2020 22:10, Larry Garfield wrote:
>>> What do you think the new default be (and why)?
>>>=20
>>> (I am aware this change will likely require an RFC)
>>>=20
>>> AllenJB
>>=20
>> I see only two options:
>>=20
>> 1) Do nothing.
>>=20
>> 2) Move to Exceptions.
>>=20
>> I've never used PDO and not set it to Exceptions, honestly.  Adding =
more global error conditions to code is a terrible idea, so let's not do =
warnings.  If your query breaks, you really shouldn't continue because =
your data is busted so your following code will fail ungracefully at =
best, or corrupt data at worst.
>>=20
>> Changing a default like this seems a reasonably safe thing to do in a =
major, as long as it's still just as easy to switch back to silent mode =
for those who prefer to be explicit.
>=20
> I agree defaulting to PDO::ERRMODE_EXCEPTION is a sensible change for =
PHP8.

I think this should go through a deprecation phase first as it is a BC =
break, no matter how easy to fix you think it is.

- Chris