Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109139
To: Larry Garfield <larry@garfieldtech.com>,
 php internals <internals@lists.php.net>
References: <99c00084-c212-ad23-628e-87f35e2de849@allenjb.me.uk>
 <782751cf-0058-4dae-9f5a-40648a79986d@www.fastmail.com>
Message-ID: <c10fcdfb-465c-4516-242c-1a554b0f4e5c@beccati.com>
Date: Thu, 19 Mar 2020 10:31:48 +0100
MIME-Version: 1.0
In-Reply-To: <782751cf-0058-4dae-9f5a-40648a79986d@www.fastmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Changing the default PDO error mode
From: php@beccati.com (Matteo Beccati)

Hi,

On 14/03/2020 22:10, Larry Garfield wrote:
>> What do you think the new default be (and why)?
>>
>> (I am aware this change will likely require an RFC)
>>
>> AllenJB
> 
> I see only two options:
> 
> 1) Do nothing.
> 
> 2) Move to Exceptions.
> 
> I've never used PDO and not set it to Exceptions, honestly.  Adding more global error conditions to code is a terrible idea, so let's not do warnings.  If your query breaks, you really shouldn't continue because your data is busted so your following code will fail ungracefully at best, or corrupt data at worst.
> 
> Changing a default like this seems a reasonably safe thing to do in a major, as long as it's still just as easy to switch back to silent mode for those who prefer to be explicit.

I agree defaulting to PDO::ERRMODE_EXCEPTION is a sensible change for PHP8.


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/