Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109106
MIME-Version: 1.0
References: <CAJmjfvW8b=jYTjLfW9N9FT_eQVS7RBe768NZXv-g4V2RM3OgtA@mail.gmail.com>
 <CAJmjfvVekTvzB7FKADyt1dTygORZNK6Hrfh=bWf-PA73HsLQyw@mail.gmail.com>
In-Reply-To: <CAJmjfvVekTvzB7FKADyt1dTygORZNK6Hrfh=bWf-PA73HsLQyw@mail.gmail.com>
Date: Tue, 17 Mar 2020 16:52:06 +0100
Message-ID: <CABdc3Wpb20HztnkS3T8-ec=FA1K=p_WE7sQs1v6ei6CJDHByZg@mail.gmail.com>
To: Jakob Givoni <jakob@givoni.dk>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009119d605a10eeb87"
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] Compact Object Property Assignment
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Brzuchalski?=)

--0000000000009119d605a10eeb87
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Jakob,

wt., 17 mar 2020 o 03:08 Jakob Givoni <jakob@givoni.dk> napisa=C5=82(a):

> On Mon, Mar 16, 2020 at 6:48 AM Jakob Givoni <jakob@givoni.dk> wrote:
> > Let me know what you think!
>
> Thank you for your feedback so far!
>
> I'd be really curios to know what authors of the referenced RFCs think
> about this, f.ex.
> Micha=C5=82 (brzuchal@php.net), Andrey (andrewgrom@rambler.ru) and Nikita
> (nikic@php.net)
>
> Is simple inline object population useful in itself?
> Is the proposed implementation as trivial as I think it is?
>

For object initializer, I was hoping to introduce a feature which with the
benefits of typed properties
could reduce the boilerplate on initializing object and setting their
properties in one expression.

This is somewhat what I personally do a lot for commands and events
construction where
those simply have public typed properties and I don't care if something
would be changed
in the meantime.

With current RFC for write-once, I can see object initializer could be an
awesome feature
with a combine of read-only properties.

Currently I would have to do a lot of:

$command =3D new SomeCommand();
$command->foo =3D 'bar';
$command->baz =3D true

$this->dispatch($command);

For SomeCommand looking like (with read-only for example purposes)
class SomeCommand {
    public readonly string $foo;
    public readonly bool $baz;
}

With object initializer, this could be reduced to:

$this->dispatch(new SomeCommand { foo =3D 'bar', baz =3D false });

But as mentioned IMO this is a different feature than what you propose and
personally I see no point
in reducing only assignment statements without combining it with object
construction for these kinds
of small objects, DTO's, commands, queries and events.

And agree with others that brackets look unnatural for anything related to
objects.

IIRC there were many questions about named parameters to pass for object
constructor or proper
property setters like in C#, but personally I don't need a constructor at
all in those cases since we
have typed properties and it looks like they could be also marked as
read-only in next major PHP version.

Cheers,
--
Micha=C5=82 Brzuchalski

--0000000000009119d605a10eeb87--