Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:109087
MIME-Version: 1.0
References: <CAJmjfvW8b=jYTjLfW9N9FT_eQVS7RBe768NZXv-g4V2RM3OgtA@mail.gmail.com>
 <CADyq6sJ_aUvoUs_vyhX4x1c7jApAFzDJrZy+DzUxhc-y9owJFQ@mail.gmail.com> <CAJmjfvWtFr0vb+ZAku0CJW5HTtwiyDdza1NtcSkcx8x3Yo6RGQ@mail.gmail.com>
In-Reply-To: <CAJmjfvWtFr0vb+ZAku0CJW5HTtwiyDdza1NtcSkcx8x3Yo6RGQ@mail.gmail.com>
Date: Tue, 17 Mar 2020 02:29:25 +0100
Message-ID: <CADyq6sJek9FwDkmf=S3zD9yHRKpZRYTSk4GCWDJZZCvC3U2ZuQ@mail.gmail.com>
To: Jakob Givoni <jakob@givoni.dk>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000006f924c05a102de78"
Subject: Re: [PHP-DEV] [RFC] [DISCUSSION] Compact Object Property Assignment
From: ocramius@gmail.com (Marco Pivetta)

--0000000000006f924c05a102de78
Content-Type: text/plain; charset="UTF-8"

Hey Jakob,

On Tue, Mar 17, 2020, 02:27 Jakob Givoni <jakob@givoni.dk> wrote:

> On Mon, Mar 16, 2020 at 9:31 AM Marco Pivetta <ocramius@gmail.com> wrote:
> > What happens if you have an expression that throws?
> >
> > class Foo
> > {
> >     public $a;
> >     public $b;
> >     public $c;
> > }
> >
> > $instance = new Foo();
> >
> > function iThrow() {
> >     throw new \Exception();
> > }
> >
> > try {
> >     $foo ->[
> >         a = 'a',
> >         b = iThrow(),
> >         c = 'c',
> >     ];
> > } catch (\Throwable $e) {
> >     var_export($foo); // ???
> > }
>
> Hi Marco!
> Trivial question - let's see what happens:
>
> Just replace COPA with the old syntax and run it:
>
> try {
>     $foo->a = 'a';
>     $foo->b = iThrow();
>     $foo->x = 'c';
> } catch (\Throwable $e) {
>     var_export($foo); // ???
> }
>
> Result:
> Foo::__set_state(array(
>    'a' => 'a',
>    'b' => NULL,
>    'c' => NULL,
> ))
>
> So the first property will be set, the rest will be left as they were.
>

That kinda makes the entire feature quite useless/uninteresting to me: if a
this does is desugaring into a set of assignments, then I'm not sure what
its advantage is.

I was kinda hoping for an atomic state mutation across multiple fields,
heh...

>

--0000000000006f924c05a102de78--